From: Tejun Heo <tj@kernel.org>
To: Jeff Garzik <jeff@garzik.org>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
Antonio Toma <antonio.toma@gmail.com>, stable <stable@kernel.org>
Subject: Re: [PATCH #upstream-fixes] libata-sff: fix HSM_ST_ERR handling in __ata_sff_port_intr()
Date: Fri, 24 Dec 2010 16:20:10 +0100 [thread overview]
Message-ID: <20101224152010.GD11419@htj.dyndns.org> (raw)
In-Reply-To: <4CF8FC61.8060606@kernel.org>
On Fri, Dec 03, 2010 at 03:19:13PM +0100, Tejun Heo wrote:
> While separating out BMDMA irq handler from SFF, commit c3b28894
> (libata-sff: separate out BMDMA irq handler) incorrectly made
> __ata_sff_port_intr() consider an IRQ to be an idle one if the host
> state was transitioned to HSM_ST_ERR by ata_bmdma_port_intr().
>
> This makes BMDMA drivers ignore IRQs reporting host bus error which
> leads to timeouts instead of triggering EH immediately. Fix it by
> making __ata_sff_port_intr() consider the IRQ to be an idle one iff
> the state is HSM_ST_IDLE. This is equivalent to adding HSM_ST_ERR to
> the "break"ing case but less error-prone.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Reported-by: Antonio Toma <antonio.toma@gmail.com>
> Cc: stable@kernel.org
Ping.
--
tejun
next prev parent reply other threads:[~2010-12-24 15:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-03 14:19 [PATCH #upstream-fixes] libata-sff: fix HSM_ST_ERR handling in __ata_sff_port_intr() Tejun Heo
2010-12-24 15:20 ` Tejun Heo [this message]
2010-12-24 18:39 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101224152010.GD11419@htj.dyndns.org \
--to=tj@kernel.org \
--cc=antonio.toma@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).