From: David Miller <davem@davemloft.net>
To: tj@kernel.org
Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org,
kay.sievers@vrfy.org, hch@infradead.org,
linux-ide@vger.kernel.org
Subject: Re: [PATCH 04/16] ide: convert to bdops->check_events()
Date: Tue, 28 Dec 2010 11:01:06 -0800 (PST) [thread overview]
Message-ID: <20101228.110106.226787796.davem@davemloft.net> (raw)
In-Reply-To: <1293557352-10592-5-git-send-email-tj@kernel.org>
From: Tejun Heo <tj@kernel.org>
Date: Tue, 28 Dec 2010 18:29:00 +0100
> Convert ->media_changed() to the new ->check_events() method. The
> conversion is mostly mechanical. The only notable change is that
> cdrom now doesn't generate any event if @slot_nr isn't CDSL_CURRENT.
> It used to return -EINVAL which would be treated as media changed. As
> media changer isn't supported anyway, this doesn't make any
> difference.
>
> This makes ide emit the standard disk events and allows kernel event
> polling. Currently, only MEDIA_CHANGE event is implemented. Adding
> support for EJECT_REQUEST shouldn't be difficult; however, given that
> ide driver is already deprecated, it probably is best to leave it
> alone.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
Acked-by: David S. Miller <davem@davemloft.net>
next prev parent reply other threads:[~2010-12-28 19:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1293557352-10592-1-git-send-email-tj@kernel.org>
2010-12-28 17:29 ` [PATCH 04/16] ide: convert to bdops->check_events() Tejun Heo
2010-12-28 19:01 ` David Miller [this message]
[not found] <1299662016-7721-1-git-send-email-tj@kernel.org>
2011-03-09 9:13 ` [PATCH 04/16] ide: Convert " Tejun Heo
2011-03-09 22:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101228.110106.226787796.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=kay.sievers@vrfy.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).