From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 04/16] ide: convert to bdops->check_events() Date: Tue, 28 Dec 2010 11:01:06 -0800 (PST) Message-ID: <20101228.110106.226787796.davem@davemloft.net> References: <1293557352-10592-1-git-send-email-tj@kernel.org> <1293557352-10592-5-git-send-email-tj@kernel.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:38969 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753247Ab0L1TAi (ORCPT ); Tue, 28 Dec 2010 14:00:38 -0500 In-Reply-To: <1293557352-10592-5-git-send-email-tj@kernel.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: tj@kernel.org Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org, kay.sievers@vrfy.org, hch@infradead.org, linux-ide@vger.kernel.org From: Tejun Heo Date: Tue, 28 Dec 2010 18:29:00 +0100 > Convert ->media_changed() to the new ->check_events() method. The > conversion is mostly mechanical. The only notable change is that > cdrom now doesn't generate any event if @slot_nr isn't CDSL_CURRENT. > It used to return -EINVAL which would be treated as media changed. As > media changer isn't supported anyway, this doesn't make any > difference. > > This makes ide emit the standard disk events and allows kernel event > polling. Currently, only MEDIA_CHANGE event is implemented. Adding > support for EJECT_REQUEST shouldn't be difficult; however, given that > ide driver is already deprecated, it probably is best to leave it > alone. > > Signed-off-by: Tejun Heo Acked-by: David S. Miller