Re: [Patch] Enable AHCI on certain ich chipsets

[Joerg Dorchain <joerg@dorchain.net>]

[-- Attachment #1: Type: text/plain, Size: 1449 bytes --]

On Fri, Feb 11, 2011 at 11:50:06PM +0300, Sergei Shtylyov wrote:
> 
> >Well, the functionality of the patch to quirks.c is described in
> >the comments on the top of it. Should that be repeated?
> 
>    Yes, certainly.

Ok, will do so.
> 
> >>And looks like it
> >>should be in a patch of its own...
> 
> >I need both parts in order to use the AHCI driver and having
> >suspend/resume work, hence they are together.
> 
> 
> They are solving two different issues, as far as I understand, hence
> should be in two different patches. One issue per patch is the basic
> rule.

Here I am not sure. Suspend/resume works fine (for me) without
any of the patches. The first patch fiddles with pci config space
in order to achieve something that  which should be done by the
BIOS, hence it is in quirks, together with other workarounds.

The second part just makes sure that the config space change is
kept after a resume. Otherwise it comes up as a different PCI
id, the AHCI driver finds nothing to work with, the harddisk is
gone after resume, not good.

You could also see it as it triggers a general fault, and
should be fixed anyway indepent of the trigger case.

Whereas I am quite sure about the quirks part, I'd be glad for
some functional review of the ahci part, to avoid undesired side
effects.
> 
> 
> scripts/checkpatch.pl -- it notices such style violations.

Thank you for that hint.

Bye,

Joerg

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 267 bytes --]