From: Tejun Heo <tj@kernel.org>
To: Lin Mac <mkl0301@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: Question regarding PORT_IRQ_BAD_PMP (Re: AHCI support Port Multiplier problem.)
Date: Tue, 15 Feb 2011 11:03:49 +0100 [thread overview]
Message-ID: <20110215100335.GH3160@htj.dyndns.org> (raw)
In-Reply-To: <AANLkTimG0Y2XjRTmaSLs0uq4h-zoz-x+k_eA-2Abxmg9@mail.gmail.com>
On Tue, Feb 15, 2011 at 05:50:55PM +0800, Lin Mac wrote:
> > You're already working around buggy hardware. It isn't surprising
> > that both behave incorrectly in their own separate ways. Just do
> > what's necessary to get the hardware working as long as the workaround
> > is localized to the specific controller.
>
> If I implement it as a quirk, would you prefer to add a new field
> quirk, or just use flags of ahci_host_priv and add a new AHCI_HFLAG*?
> I prefer the later, but afraid that it's not what it is for.
Please implement it as a separate ata_port_operations like
ahci_CONTROLLER_NAME_ops and use the customized reset methods.
--
tejun
next prev parent reply other threads:[~2011-02-15 10:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-07 2:55 AHCI support Port Multiplier problem Luo Dislo
2011-01-07 21:25 ` Tejun Heo
2011-01-10 1:46 ` Luo Dislo
2011-01-10 15:42 ` Mac Lin
2011-01-11 1:54 ` Robert Hancock
2011-01-11 14:39 ` Tejun Heo
2011-01-11 14:37 ` Tejun Heo
2011-01-12 1:26 ` Luo Dislo
2011-01-13 8:16 ` Luo Dislo
2011-02-15 7:48 ` Question regarding PORT_IRQ_BAD_PMP (Re: AHCI support Port Multiplier problem.) Mac Lin
2011-02-15 8:55 ` Tejun Heo
2011-02-15 9:50 ` Lin Mac
2011-02-15 10:03 ` Tejun Heo [this message]
2011-02-15 10:26 ` Lin Mac
2011-02-15 10:31 ` Tejun Heo
2011-02-15 13:00 ` Lin Mac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110215100335.GH3160@htj.dyndns.org \
--to=tj@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=mkl0301@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).