From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: Question regarding PORT_IRQ_BAD_PMP (Re: AHCI support Port Multiplier problem.) Date: Tue, 15 Feb 2011 11:03:49 +0100 Message-ID: <20110215100335.GH3160@htj.dyndns.org> References: <20110107212537.GH7355@mtj.dyndns.org> <55871.3142.qm@web74203.mail.tp2.yahoo.com> <20110111143726.GE30607@htj.dyndns.org> <20110215085504.GA3160@htj.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-fx0-f46.google.com ([209.85.161.46]:40309 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751769Ab1BOKJU (ORCPT ); Tue, 15 Feb 2011 05:09:20 -0500 Received: by fxm20 with SMTP id 20so6194545fxm.19 for ; Tue, 15 Feb 2011 02:09:19 -0800 (PST) Content-Disposition: inline In-Reply-To: Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Lin Mac Cc: linux-ide@vger.kernel.org On Tue, Feb 15, 2011 at 05:50:55PM +0800, Lin Mac wrote: > > You're already working around buggy hardware. =A0It isn't surprisin= g > > that both behave incorrectly in their own separate ways. =A0Just do > > what's necessary to get the hardware working as long as the workaro= und > > is localized to the specific controller. > > If I implement it as a quirk, would you prefer to add a new field > quirk, or just use flags of ahci_host_priv and add a new AHCI_HFLAG*? > I prefer the later, but afraid that it's not what it is for. Please implement it as a separate ata_port_operations like ahci_CONTROLLER_NAME_ops and use the customized reset methods. --=20 tejun