linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joerg Dorchain <joerg@dorchain.net>
To: Tejun Heo <tj@kernel.org>
Cc: linux-ide@vger.kernel.org
Subject: Re: [Patch] enable AHCI mode on certain ich chipsets
Date: Thu, 17 Feb 2011 19:09:39 +0100	[thread overview]
Message-ID: <20110217180939.GT5778@Redstar.dorchain.net> (raw)
In-Reply-To: <20110217100330.GO19830@htj.dyndns.org>

[-- Attachment #1: Type: text/plain, Size: 868 bytes --]

On Thu, Feb 17, 2011 at 11:03:30AM +0100, Tejun Heo wrote:
> 
> I'm not particularly inclined toward including this patch in upstream
> as long as it can't be enabled by default.  It's just gonna be an
> extra piece of code to carry around which only a handful of people use
> and nobody really knows on which hardware it works or not and to what
> extent.

I have a feedback for the chipsets listed in the patch. The
protection via the extra parameter is owned to the fact that
intel recommends against the OS doing this. Quote: "SW shall not
manipulate SMS during runtime operation; that is, the OS will not
do this." I would not see early fixup as runtime, however, better
save than sorry.

Advantages are better performance and lower power consumption.

I don't wanna break anybody's data with that patch, hence the
precaution.

Bye,

Joerg

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 267 bytes --]

  reply	other threads:[~2011-02-17 18:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-16  9:05 [Patch] enable AHCI mode on certain ich chipsets Joerg Dorchain
2011-02-16 19:45 ` Jeff Garzik
2011-02-17 16:36   ` Matthew Garrett
2011-02-17 22:52     ` Mark Lord
2011-02-17 17:42   ` Joerg Dorchain
2011-02-17 10:03 ` Tejun Heo
2011-02-17 18:09   ` Joerg Dorchain [this message]
2011-02-18 14:03   ` Bjørn Mork
2011-02-18 14:42     ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110217180939.GT5778@Redstar.dorchain.net \
    --to=joerg@dorchain.net \
    --cc=linux-ide@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).