From: Tejun Heo <tj@kernel.org>
To: Hannes Reinecke <hare@suse.de>
Cc: jgarzik@pobox.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: Include WWN ID in inquiry VPD emulation
Date: Fri, 4 Mar 2011 18:09:04 +0100 [thread overview]
Message-ID: <20110304170904.GW20499@htj.dyndns.org> (raw)
In-Reply-To: <20110304085501.8B331F90E1@ochil.suse.de>
Hello, Hannes.
On Fri, Mar 04, 2011 at 09:55:01AM +0100, Hannes Reinecke wrote:
> +static inline int ata_id_has_wwn(const u16 *id)
> +{
> + if ((id[ATA_ID_CSF_DEFAULT] & 0xC000) != 0x4000)
> + return 0;
> + return id[ATA_ID_CSF_DEFAULT] & (1 << 8);
> +}
Can you please make this return bool? Otherwise,
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
next prev parent reply other threads:[~2011-03-04 17:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-04 8:55 [PATCH] libata: Include WWN ID in inquiry VPD emulation Hannes Reinecke
2011-03-04 11:17 ` Sergei Shtylyov
2011-03-04 11:36 ` Hannes Reinecke
2011-03-04 17:09 ` Tejun Heo [this message]
2011-03-04 17:22 ` Jeff Garzik
2011-03-07 7:57 ` Hannes Reinecke
2011-03-07 8:27 ` Jeff Garzik
2011-03-07 8:53 ` Hannes Reinecke
2011-03-14 7:01 ` Jeff Garzik
2011-03-14 15:56 ` Hannes Reinecke
-- strict thread matches above, loose matches on Subject: below --
2011-03-07 7:56 Hannes Reinecke
2011-03-14 7:00 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110304170904.GW20499@htj.dyndns.org \
--to=tj@kernel.org \
--cc=hare@suse.de \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).