From: Tejun Heo <htejun@gmail.com>
To: Maxime Bizon <mbizon@freebox.fr>
Cc: Robert Hancock <hancockrwd@gmail.com>,
Jeff Garzik <jgarzik@pobox.com>,
linux-ide <linux-ide@vger.kernel.org>
Subject: Re: "irq 4: nobody cared" when loading ahci driver on ce4100
Date: Tue, 15 Mar 2011 16:19:31 +0100 [thread overview]
Message-ID: <20110315151931.GA17376@htj.dyndns.org> (raw)
In-Reply-To: <1300201422.10827.39.camel@sakura.staff.proxad.net>
On Tue, Mar 15, 2011 at 04:03:42PM +0100, Maxime Bizon wrote:
>
> On Tue, 2011-03-15 at 15:48 +0100, Maxime Bizon wrote:
>
> > no it doesn't, but this one does:
>
> sorry it does not compile, missing ')', but actually works
>
> I will send a proper patch if you agree with this solution
Hmm... I don't really like INITIALIZING being tested there. It's much
more cumbersome to explain. Can you please change ata_port_alloc() to
set pflags to INITIALIZING|FROZEN? And add a comment in ahci briefly
noting why the test is necessary?
Thanks.
--
tejun
next prev parent reply other threads:[~2011-03-15 15:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-14 19:08 "irq 4: nobody cared" when loading ahci driver on ce4100 Maxime Bizon
2011-03-15 0:59 ` Robert Hancock
2011-03-15 4:20 ` Maxime Bizon
2011-03-15 7:19 ` Tejun Heo
2011-03-15 14:48 ` Maxime Bizon
2011-03-15 15:03 ` Maxime Bizon
2011-03-15 15:19 ` Tejun Heo [this message]
2011-03-15 17:03 ` Maxime Bizon
2011-03-15 21:22 ` [PATCH] ahci: don't enable port irq before handler is registered Maxime Bizon
2011-03-16 9:04 ` Tejun Heo
2011-03-16 9:05 ` Tejun Heo
2011-03-16 13:58 ` [PATCH v2] " Maxime Bizon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110315151931.GA17376@htj.dyndns.org \
--to=htejun@gmail.com \
--cc=hancockrwd@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=mbizon@freebox.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).