linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Herrmann <morpheus.ibis@gmail.com>
To: linux-ide@vger.kernel.org
Subject: [PATCH] support for PMP used in TT BlackX Duet drive dock
Date: Thu, 7 Apr 2011 18:54:10 +0200	[thread overview]
Message-ID: <201104071854.10911.morpheus.ibis@gmail.com> (raw)

[-- Attachment #1: Type: Text/Plain, Size: 449 bytes --]

Hi,

Current linux kernel failes to communicate with PMP chip used in Thermaltake 
BlackX Duet (ST0015E) external drive, adding same quirks (some of them may not 
be necessary) as other chips have fixes it (tested on AHCI driver, on JMB363 
and ICH10R)

Please note that this patch is purposefully not in state includable in 
mainline, it is meant as a base for someone with more understanding of libata 
to make a proper fix

Thanks
Pavel Herrmann

[-- Attachment #2: 0001-libata-pmp-add-support-for-Thermaltake-BlackX-Duet-e.patch --]
[-- Type: text/x-patch, Size: 1268 bytes --]

From f1c2e6ec61c978846d6d3dadacc7c1b2997140a6 Mon Sep 17 00:00:00 2001
From: Pavel Herrmann <morpheus.ibis@gmail.com>
Date: Thu, 7 Apr 2011 18:15:26 +0200
Subject: [PATCH] libata-pmp: add support for Thermaltake BlackX Duet esata drive dock

some errors still show up, but the dock works, both drives can be
accessed at the same time

the chip maker and designation is unknown - possibly jmicron JMB350?

Signed-off-by: Pavel Herrmann <morpheus.ibis@gmail.com>
---
 drivers/ata/libata-pmp.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/drivers/ata/libata-pmp.c b/drivers/ata/libata-pmp.c
index 3120596..9ceef00 100644
--- a/drivers/ata/libata-pmp.c
+++ b/drivers/ata/libata-pmp.c
@@ -449,6 +449,14 @@ static void sata_pmp_quirks(struct ata_port *ap)
 		 * otherwise.  Don't try hard to recover it.
 		 */
 		ap->pmp_link[ap->nr_pmp_links - 1].flags |= ATA_LFLAG_NO_RETRY;
+		}
+	} else if (vendor == 0x1095 && devid == 0x4726) {
+		/* chip found in Thermaltake BlackX Duet */
+		ata_for_each_link(link, ap, EDGE) {
+			/* Use same quirks as sil chips	to make it work */
+			link->flags |= ATA_LFLAG_NO_LPM |
+				       ATA_LFLAG_NO_SRST |
+				       ATA_LFLAG_ASSUME_ATA;
 	}
 }
 
-- 
1.7.4.1


             reply	other threads:[~2011-04-07 16:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-07 16:54 Pavel Herrmann [this message]
2011-04-07 17:08 ` [PATCH] support for PMP used in TT BlackX Duet drive dock Pavel Herrmann
2011-04-07 19:03   ` Tejun Heo
2011-04-07 19:40     ` Pavel Herrmann
2011-04-08  4:58       ` Jeff Garzik
2011-04-08  8:05         ` Pavel Herrmann
2011-04-08 15:59           ` Tejun Heo
2011-04-08 17:13             ` Pavel Herrmann
2011-04-10 21:30               ` Tejun Heo
2011-04-28 19:29                 ` Pavel Herrmann
2011-04-28 19:55                   ` Tejun Heo
2011-04-28 19:57                   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201104071854.10911.morpheus.ibis@gmail.com \
    --to=morpheus.ibis@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).