linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Herrmann <morpheus.ibis@gmail.com>
To: Tejun Heo <tj@kernel.org>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] support for PMP used in TT BlackX Duet drive dock
Date: Thu, 7 Apr 2011 21:40:59 +0200	[thread overview]
Message-ID: <201104072140.59548.morpheus.ibis@gmail.com> (raw)
In-Reply-To: <20110407190300.GA8841@mtj.dyndns.org>

On Thursday 07 of April 2011 21:03:00 Tejun Heo wrote:
> I'm confused.  Against which version is the patch generated?  Upstream
> already has quirks for 4726.
> 
> Thakns.

this is what you get from running and editing a different tree (and being 
lazy), sorry for messing it up.

the correct (tested) code, without beautifications/comments:

        } else if (vendor == 0x197b && devid == 0x2352) {
                ata_for_each_link(link, ap, EDGE) {
                        link->flags |= ATA_LFLAG_NO_LPM |
                                       ATA_LFLAG_NO_SRST |
                                       ATA_LFLAG_ASSUME_ATA;
                }
        }

third time's the charm

Thanks
Pavel Herrmann

PS: just to be on the safe side, this is the device detection from dmesg
ata8.15: Port Multiplier 1.1, 0x197b:0x2352 r0, 2 ports, feat 0x0/0x0

  reply	other threads:[~2011-04-07 19:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-07 16:54 [PATCH] support for PMP used in TT BlackX Duet drive dock Pavel Herrmann
2011-04-07 17:08 ` Pavel Herrmann
2011-04-07 19:03   ` Tejun Heo
2011-04-07 19:40     ` Pavel Herrmann [this message]
2011-04-08  4:58       ` Jeff Garzik
2011-04-08  8:05         ` Pavel Herrmann
2011-04-08 15:59           ` Tejun Heo
2011-04-08 17:13             ` Pavel Herrmann
2011-04-10 21:30               ` Tejun Heo
2011-04-28 19:29                 ` Pavel Herrmann
2011-04-28 19:55                   ` Tejun Heo
2011-04-28 19:57                   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201104072140.59548.morpheus.ibis@gmail.com \
    --to=morpheus.ibis@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).