Re: [PATCH] support for PMP used in TT BlackX Duet drive dock

[Pavel Herrmann <morpheus.ibis@gmail.com>]

[-- Attachment #1: Type: Text/Plain, Size: 353 bytes --]

On Friday 08 of April 2011 06:58:45 Jeff Garzik wrote:
> So you're gonna resend this as a real patch, right?  :)

right :)

this is the tested version (call it V2 if you wish), against 29-rc2 and 28-
gentoo-r1 (no difference in this file), works in both

I still have no idea what those quirks really do, so test before including

thanks
Pavel Herrmann

[-- Attachment #2: 0001-libata-pmp-add-support-for-Thermaltake-BlackX-Duet-e.patch --]
[-- Type: text/x-patch, Size: 1344 bytes --]

From a7b09f275faca338805fd697ab41fd13d7f21d41 Mon Sep 17 00:00:00 2001
From: Pavel Herrmann <morpheus.ibis@gmail.com>
Date: Thu, 7 Apr 2011 18:15:26 +0200
Subject: [PATCH] libata-pmp: add support for Thermaltake BlackX Duet esata drive dock

some errors still show up, but the dock works, both drives can be
accessed at the same time

the chip maker and designation is unknown - possibly jmicron JMB350?

Signed-off-by: Pavel Herrmann <morpheus.ibis@gmail.com>
---
 drivers/ata/libata-pmp.c |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/drivers/ata/libata-pmp.c b/drivers/ata/libata-pmp.c
index 3120596..e6e409d 100644
--- a/drivers/ata/libata-pmp.c
+++ b/drivers/ata/libata-pmp.c
@@ -449,6 +449,16 @@ static void sata_pmp_quirks(struct ata_port *ap)
 		 * otherwise.  Don't try hard to recover it.
 		 */
 		ap->pmp_link[ap->nr_pmp_links - 1].flags |= ATA_LFLAG_NO_RETRY;
+	} else if (vendor == 0x197b && devid == 0x2352) {
+		/* chip found in Thermaltake BlackX Duet, jmicron JMB350? */
+		ata_for_each_link(link, ap, EDGE) {
+			/* Use same quirks as sil chips	to make it work,
+			 * not everything might be necessary though
+			 */
+			link->flags |= ATA_LFLAG_NO_LPM |
+				       ATA_LFLAG_NO_SRST |
+				       ATA_LFLAG_ASSUME_ATA;
+		}
 	}
 }
 
-- 
1.7.4.1