linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Pavel Herrmann <morpheus.ibis@gmail.com>
Cc: Jeff Garzik <jeff@garzik.org>, linux-ide@vger.kernel.org
Subject: Re: [PATCH] support for PMP used in TT BlackX Duet drive dock
Date: Fri, 8 Apr 2011 08:59:18 -0700	[thread overview]
Message-ID: <20110408155918.GA3871@mtj.dyndns.org> (raw)
In-Reply-To: <201104081005.37191.morpheus.ibis@gmail.com>

Hey,

On Fri, Apr 08, 2011 at 10:05:37AM +0200, Pavel Herrmann wrote:
> +	} else if (vendor == 0x197b && devid == 0x2352) {
> +		/* chip found in Thermaltake BlackX Duet, jmicron JMB350? */
> +		ata_for_each_link(link, ap, EDGE) {
> +			/* Use same quirks as sil chips	to make it work,
> +			 * not everything might be necessary though
> +			 */
> +			link->flags |= ATA_LFLAG_NO_LPM |
> +				       ATA_LFLAG_NO_SRST |
> +				       ATA_LFLAG_ASSUME_ATA;
> +		}

Can you please do the followings?

* Post dmesg w/o the patch.

* Try different combinations of the flags and see which ones are
  essential.

Thanks.

-- 
tejun

  reply	other threads:[~2011-04-08 15:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-07 16:54 [PATCH] support for PMP used in TT BlackX Duet drive dock Pavel Herrmann
2011-04-07 17:08 ` Pavel Herrmann
2011-04-07 19:03   ` Tejun Heo
2011-04-07 19:40     ` Pavel Herrmann
2011-04-08  4:58       ` Jeff Garzik
2011-04-08  8:05         ` Pavel Herrmann
2011-04-08 15:59           ` Tejun Heo [this message]
2011-04-08 17:13             ` Pavel Herrmann
2011-04-10 21:30               ` Tejun Heo
2011-04-28 19:29                 ` Pavel Herrmann
2011-04-28 19:55                   ` Tejun Heo
2011-04-28 19:57                   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110408155918.GA3871@mtj.dyndns.org \
    --to=tj@kernel.org \
    --cc=jeff@garzik.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=morpheus.ibis@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).