From: David Miller <davem@davemloft.net>
To: tj@kernel.org
Cc: jaxboe@fusionio.com, torvalds@linux-foundation.org, hch@lst.de,
neilb@suse.de, linux-kernel@vger.kernel.org,
linux-ide@vger.kernel.org, kay.sievers@vrfy.org
Subject: Re: [PATCH 2/2] ide: unexport DISK_EVENT_MEDIA_CHANGE for ide-gd and ide-cd
Date: Thu, 21 Apr 2011 10:14:04 -0700 (PDT) [thread overview]
Message-ID: <20110421.101404.02262055.davem@davemloft.net> (raw)
In-Reply-To: <20110421170925.GD15988@htj.dyndns.org>
From: Tejun Heo <tj@kernel.org>
Date: Thu, 21 Apr 2011 19:09:25 +0200
> check_events() implementations in both ide-gd and ide-cd are
> inadequate for in-kernel event polling. Both generate media change
> events continuously when certain conditions are met causing infinite
> event loop between the driver and userland event handler.
>
> As disk event now supports suppression of unlisted events, simply
> de-listing DISK_EVENT_MEDIA_CHANGE from disk->events resolves the
> problem. Internal handling around media revalidation will behave the
> same while userland will fall back to userland event polling after
> detecting the device doesn't support disk events.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Reported-by: Jens Axboe <jaxboe@fusionio.com>
Acked-by: David S. Miller <davem@davemloft.net>
next prev parent reply other threads:[~2011-04-21 17:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-21 17:08 [PATCH 1/2] block: don't propagate unlisted DISK_EVENTs to userland Tejun Heo
2011-04-21 17:09 ` [PATCH 2/2] ide: unexport DISK_EVENT_MEDIA_CHANGE for ide-gd and ide-cd Tejun Heo
2011-04-21 17:14 ` David Miller [this message]
2011-04-21 17:25 ` [PATCH 1/2] block: don't propagate unlisted DISK_EVENTs to userland Linus Torvalds
2011-04-21 17:27 ` David Miller
2011-04-21 17:31 ` Jens Axboe
2011-04-21 17:46 ` Jens Axboe
2011-04-21 18:02 ` Shaun Ruffell
2011-04-21 18:10 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110421.101404.02262055.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hch@lst.de \
--cc=jaxboe@fusionio.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).