From: David Miller <davem@davemloft.net>
To: cmdkhh@gmail.com
Cc: bp@alien8.de, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ide-cd: Fix another signedness warning
Date: Tue, 31 May 2011 15:24:45 -0700 (PDT) [thread overview]
Message-ID: <20110531.152445.44639723.davem@davemloft.net> (raw)
In-Reply-To: <1306740418-565-1-git-send-email-cmdkhh@gmail.com>
From: Connor Hansen <cmdkhh@gmail.com>
Date: Mon, 30 May 2011 00:26:58 -0700
> One of the legit warnings 'make W=3 drivers/ide/ide-cd.o generates is
>
> drivers/ide/ide-cd.c: In function ide_cd_queue_pc:
> drivers/ide/ide-cd.c:451:3: warning: conversion to unsigned int from
> int may change the sign of the result
>
> timeout is passed as an int, but is declared as an unsigned int in
> struct request in include/linux/blkdev.h
>
> Signed-off-by: Connor Hansen <cmdkhh@gmail.com>
This is beyond academic and may in fact introduce strange things.
All except one call site passes "0" for the timeout.
And that one call site passes packet_command->timeout from userspace
which is an 'int'.
I'm not applying this.
prev parent reply other threads:[~2011-05-31 22:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-30 7:26 [PATCH 2/2] ide-cd: Fix another signedness warning Connor Hansen
2011-05-31 22:24 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110531.152445.44639723.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bp@alien8.de \
--cc=cmdkhh@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox