[PATCH] libata: Pioneer DVR-216D can't do SETXFER

[PATCH] libata: Pioneer DVR-216D can't do SETXFER

[Jeff Mahoney]

 Commit 4a5610a04d415ed94af75bb1159d2621d62c8328 fixed an issue with
 the Pioneer DVR-212D not handling SETXFER correctly. An openSUSE user
 reported a similar issue with his DVR-216D that the NOSETXFER horkage
 worked around for him as well.

 This patch adds the DVR-216D (1.08) to the horkage list for NOSETXFER.

 The issue was reported at:
 https://bugzilla.novell.com/show_bug.cgi?id=679143

Reported-by: Volodymyr Kyrychenko <vladimir.kirichenko@gmail.com>
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
---
 drivers/ata/libata-core.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -4138,6 +4138,7 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
 	 */
 	{ "PIONEER DVD-RW  DVRTD08",	"1.00",	ATA_HORKAGE_NOSETXFER },
 	{ "PIONEER DVD-RW  DVR-212D",	"1.28", ATA_HORKAGE_NOSETXFER },
+	{ "PIONEER DVD-RW  DVR-216D",	"1.08", ATA_HORKAGE_NOSETXFER },
 
 	/* End Marker */
 	{ }

-- 
Jeff Mahoney
SUSE Labs

Re: [PATCH] libata: Pioneer DVR-216D can't do SETXFER

[Sergei Shtylyov]

Hello.

On 19-04-2011 19:13, Jeff Mahoney wrote:

>   Commit 4a5610a04d415ed94af75bb1159d2621d62c8328 fixed an issue with

    Please also specify that commit's summary in parens -- for the human readers.

>   the Pioneer DVR-212D not handling SETXFER correctly. An openSUSE user
>   reported a similar issue with his DVR-216D that the NOSETXFER horkage
>   worked around for him as well.

>   This patch adds the DVR-216D (1.08) to the horkage list for NOSETXFER.

>   The issue was reported at:
>   https://bugzilla.novell.com/show_bug.cgi?id=679143

> Reported-by: Volodymyr Kyrychenko <vladimir.kirichenko@gmail.com>
> Signed-off-by: Jeff Mahoney <jeffm@suse.com>

WBR, Sergei

Re: [PATCH] libata: Pioneer DVR-216D can't do SETXFER

[Jeff Mahoney]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 04/19/2011 05:05 PM, Sergei Shtylyov wrote:
> Hello.
> 
> On 19-04-2011 19:13, Jeff Mahoney wrote:
> 
>>   Commit 4a5610a04d415ed94af75bb1159d2621d62c8328 fixed an issue with
> 
>    Please also specify that commit's summary in parens -- for the human
> readers.
> 
>>   the Pioneer DVR-212D not handling SETXFER correctly. An openSUSE user
>>   reported a similar issue with his DVR-216D that the NOSETXFER horkage
>>   worked around for him as well.
> 
>>   This patch adds the DVR-216D (1.08) to the horkage list for NOSETXFER.
> 
>>   The issue was reported at:
>>   https://bugzilla.novell.com/show_bug.cgi?id=679143
> 
>> Reported-by: Volodymyr Kyrychenko <vladimir.kirichenko@gmail.com>
>> Signed-off-by: Jeff Mahoney <jeffm@suse.com>

The issue and summary are identical except for the model number.

- -Jeff

- -- 
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/

iEYEARECAAYFAk2uB1wACgkQLPWxlyuTD7Lk+ACfRWh9cqciafuYSCrTsA4/Ccci
aWcAniDuTUmJbbPGAYt6TKnQLzYiNQR5
=xpeL
-----END PGP SIGNATURE-----

Re: [PATCH] libata: Pioneer DVR-216D can't do SETXFER

[fl-00]

Unluckily, the patch is done for the pioneer dvd-216d with firmware rev. 1.08. I'm an owner with firmware rev. 1.09 and the patch does not work for me.
After some research I found lots of reports with various pioneer drives / variants concerning the same issue.

1) is it possible to include the dvd-216d with rev. 1.09 as well (or even better: with any revision)
2) is there some plan how to cope with such "broken" drives in general without the need to include every single drive in the code?

Regards,
Flo
-- 
NEU: FreePhone - kostenlos mobil telefonieren!			
Jetzt informieren: http://www.gmx.net/de/go/freephone

[PATCH #upstream-fixes] libata: apply NOSETXFER horkage to the affected drives regardless of firmware revision

[Tejun Heo]

It's unlikely NOSETXFER works for a revision of drive but doesn't for
another and pioneer doesn't seem to be fixing firmwares for the
affected drives.  Apply NOSETXFER to the affected pioneer drives
regardless of firmware revision.

  http://article.gmane.org/gmane.linux.ide/49734

Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: fl-00@gmx.de
---
> 1) is it possible to include the dvd-216d with rev. 1.09 as well (or
> even better: with any revision)

Done.

> 2) is there some plan how to cope with such "broken" drives in
> general without the need to include every single drive in the code?

Given that these are the only drives which are affected, I think it
would be better to keep quirks for these ones instead of changing the
generic behavior.

Thanks.

 drivers/ata/libata-core.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 736bee5..000d03a 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -4143,9 +4143,9 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
 	 * Devices which choke on SETXFER.  Applies only if both the
 	 * device and controller are SATA.
 	 */
-	{ "PIONEER DVD-RW  DVRTD08",	"1.00",	ATA_HORKAGE_NOSETXFER },
-	{ "PIONEER DVD-RW  DVR-212D",	"1.28", ATA_HORKAGE_NOSETXFER },
-	{ "PIONEER DVD-RW  DVR-216D",	"1.08", ATA_HORKAGE_NOSETXFER },
+	{ "PIONEER DVD-RW  DVRTD08",	NULL,	ATA_HORKAGE_NOSETXFER },
+	{ "PIONEER DVD-RW  DVR-212D",	NULL,	ATA_HORKAGE_NOSETXFER },
+	{ "PIONEER DVD-RW  DVR-216D",	NULL,	ATA_HORKAGE_NOSETXFER },
 
 	/* End Marker */
 	{ }