From: Marc MERLIN <marc@merlins.org>
To: Gwendal Grignou <gwendal@google.com>
Cc: Mark Lord <mlord@pobox.com>, Tejun Heo <tj@kernel.org>,
linux-ide@vger.kernel.org, Larry Li <lil@marvell.com>,
hbailey@marvell.com
Subject: Re: sata_mv WARNING: at drivers/ata/libata-sff.c:1322
Date: Fri, 15 Jul 2011 08:55:20 -0700 [thread overview]
Message-ID: <20110715155520.GB25319@merlins.org> (raw)
In-Reply-To: <CAMHSBOU+XHaFn_HtDTdvPr-sHEGS9MsYgCG9dUk71hLZJDaRow@mail.gmail.com>
On Thu, Jul 14, 2011 at 12:19:16AM -0700, Gwendal Grignou wrote:
> Mark,
>
> How PMP support with sata_mv broken for you? I am using marvell 7042
> and sil3726 and it works fine, but I am still using 2.6.36.
>
> Tejun, Marc,
>
> I think what happen is if a command is canceled while waiting for
> sff_pio_task to fire up, the warning may happen. The following patch
> should fix it. Marc, can you reproduce the problem easily?
>
> Thanks,
> Gwendal.
>
> diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c
> index 996a7a5..c24127d 100644
> --- a/drivers/ata/libata-sff.c
> +++ b/drivers/ata/libata-sff.c
> @@ -1333,6 +1333,7 @@ void ata_sff_flush_pio_task(struct ata_port *ap)
>
> cancel_delayed_work_sync(&ap->sff_pio_task);
> ap->hsm_task_state = HSM_ST_IDLE;
> + ap->sff_pio_task_link = NULL;
>
> if (ata_msg_ctl(ap))
> ata_port_dbg(ap, "%s: EXIT\n", __func__);
I can confirm this makes the warnings go away, thanks Gwendal.
Marc
--
"A mouse is a device used to point at the xterm you want to type in" - A.S.R.
Microsoft is to operating systems ....
.... what McDonalds is to gourmet cooking
Home page: http://marc.merlins.org/
next prev parent reply other threads:[~2011-07-15 15:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-26 7:08 decoding PMP errors with Marvel SATA controller Marc MERLIN
2011-06-26 9:03 ` Tejun Heo
2011-06-26 17:38 ` Mark Lord
2011-06-27 0:06 ` Marc MERLIN
2011-06-27 1:29 ` Mark Lord
2011-06-27 1:58 ` Hubert Bailey
2011-07-06 20:55 ` Tim Small
2011-06-29 3:41 ` Marc MERLIN
2011-06-29 3:53 ` Mark Lord
2011-06-29 5:03 ` Marc MERLIN
2011-06-29 15:07 ` sata_mv WARNING: at drivers/ata/libata-sff.c:1322 Marc MERLIN
2011-06-29 16:03 ` Mark Lord
2011-07-12 14:29 ` Tejun Heo
2011-07-13 20:54 ` Gwendal Grignou
2011-07-13 22:41 ` Mark Lord
2011-07-14 7:19 ` Gwendal Grignou
2011-07-14 12:03 ` Mark Lord
2011-07-15 15:55 ` Marc MERLIN [this message]
2011-07-16 0:32 ` [PATCH] Prevent warning during PMP error recovery Gwendal Grignou
2011-07-16 0:34 ` Gwendal Grignou
2011-07-21 7:24 ` Tejun Heo
2011-07-21 7:25 ` Tejun Heo
2011-07-22 20:48 ` Gwendal Grignou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110715155520.GB25319@merlins.org \
--to=marc@merlins.org \
--cc=gwendal@google.com \
--cc=hbailey@marvell.com \
--cc=lil@marvell.com \
--cc=linux-ide@vger.kernel.org \
--cc=mlord@pobox.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).