From: Christoph Hellwig <hch@infradead.org>
To: "Asai Thambi Samymuthu Pattrayasamy (asamymuthupa) [CONTRACTOR]"
<asamymuthupa@micron.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Jeff Moyer <jmoyer@redhat.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
Jeff Garzik <jgarzik@pobox.com>,
Christoph Hellwig <hch@infradead.org>,
Jens Axboe <jaxboe@fusionio.com>
Subject: Re: [PATCH v3 1/3] drivers/block/mtip32xx: Adding header file and source for pci and block related operation
Date: Thu, 11 Aug 2011 18:46:29 -0400 [thread overview]
Message-ID: <20110811224629.GA10182@infradead.org> (raw)
In-Reply-To: <22A973199D2C2F46933448F6E7990A3002C80025@ntxboimbx31.micron.com>
On Thu, Aug 11, 2011 at 12:52:43PM -0600, Asai Thambi Samymuthu Pattrayasamy (asamymuthupa) [CONTRACTOR] wrote:
> This is the first part of the new block driver,mtip32xx, for Micron
> PCIe SSD, which contains the header file and source for pci and
> block related operations.
There should be not split between pci/block and hardware related
functions, as there is no logical split either. Please remove that
layering and merge the files into one. Also given that the hardware
really just is AHCI with extensions please use the constants from
include/linux/ata.h and drivers/ata/ahci.h instead of redefining them.
The latter might need to be move to include/linux before merging the
driver for that, but for the next iteration a hacky relative include
might be enough.
Also please get rid of the MTIP_USE_TASKLET, if it really is worth it
it needs to be seletable at runtime.
I can't see any point of the CONFIG_PCI_MSI ifdefs - all the functions
called under it are properly stubbed out if it's not enabled.
next prev parent reply other threads:[~2011-08-11 22:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-11 18:52 [PATCH v3 1/3] drivers/block/mtip32xx: Adding header file and source for pci and block related operation Asai Thambi Samymuthu Pattrayasamy (asamymuthupa) [CONTRACTOR]
2011-08-11 22:46 ` Christoph Hellwig [this message]
2011-08-16 16:51 ` Asai Thambi S P
2011-08-12 8:04 ` Jens Axboe
2011-08-17 23:32 ` Asai Thambi S P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110811224629.GA10182@infradead.org \
--to=hch@infradead.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=asamymuthupa@micron.com \
--cc=jaxboe@fusionio.com \
--cc=jgarzik@pobox.com \
--cc=jmoyer@redhat.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).