Linux ATA/IDE development
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Dave Martin <dave.martin@linaro.org>
Cc: devicetree-discuss@lists.ozlabs.org,
	Grant Likely <grant.likely@secretlab.ca>,
	linux-ide@vger.kernel.org, Jeff Garzik <jgarzik@pobox.com>,
	linux-arm-kernel@lists.infradead.org, patches@linaro.org
Subject: Re: [PATCH] pata-generic/of: Make probing via device tree non-powerpc-specific
Date: Fri, 16 Sep 2011 22:43:13 +0100	[thread overview]
Message-ID: <20110916214313.GB16381@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1316183890-13677-1-git-send-email-dave.martin@linaro.org>

On Fri, Sep 16, 2011 at 03:38:10PM +0100, Dave Martin wrote:
> This patch enables device-tree-based probing of the pata-generic
> platform driver across all architectures:
> 
>   * make the pata_of_generic module depend on OF instead of PPC_OF;
>   * supply some missing inclues;
>   * replace endianness-sensitive raw access to device tree data
>     with of_property_read_u32() calls.
> 
> Signed-off-by: Dave Martin <dave.martin@linaro.org>
> ---
> 
> Tested on ARM Versatile Express, with my soon-to-be-posted device
> tree support patches.

This may not be the correct way to support the CF slot on Versatile
Express - it depends whether the CF slot on VE supports just CF
memory cards or whether it can take any CF card.

If the latter, then what may be inserted could be a CF network card,
and that means it's probably wrong to tell the kernel that what's
there is a PATA interface.

  parent reply	other threads:[~2011-09-16 21:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-16 14:38 [PATCH] pata-generic/of: Make probing via device tree non-powerpc-specific Dave Martin
2011-09-16 16:22 ` [PATCH v2] " Dave Martin
2011-09-16 21:34   ` Rob Herring
2011-09-19 10:10     ` Dave Martin
2011-09-20 19:30       ` Jeff Garzik
2011-09-17 15:37   ` Grant Likely
2011-09-17 18:40     ` Arnd Bergmann
2011-09-17 21:30       ` Grant Likely
2011-09-16 21:43 ` Russell King - ARM Linux [this message]
2011-09-17 18:35   ` [PATCH] " Arnd Bergmann
2011-09-19 10:05   ` Dave Martin
2011-09-19 10:23     ` Pawel Moll
2011-09-19 10:56       ` Dave Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110916214313.GB16381@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=dave.martin@linaro.org \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=jgarzik@pobox.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=patches@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox