From: Tejun Heo <htejun@gmail.com>
To: Ming Lei <ming.lei@canonical.com>
Cc: Sergei Shtylyov <sshtylyov@mvista.com>,
jgarzik@pobox.com, linux-ide@vger.kernel.org,
seth.heasley@intel.com, Alan Cox <alan@linux.intel.com>
Subject: Re: [PATCH] ata_piix: make DVD Drive recognisable on systems with Intel Sandybridge chipsets(v1)
Date: Thu, 6 Oct 2011 09:54:37 -0700 [thread overview]
Message-ID: <20111006165437.GA3953@google.com> (raw)
In-Reply-To: <CACVXFVO9TWDC-+5g2n6knWErWL4U8zNqBxy99Jc4hDB1VGzKQQ@mail.gmail.com>
Hello,
On Thu, Oct 06, 2011 at 07:53:46PM +0800, Ming Lei wrote:
> This flag is to stored into ata_port flags, so it is better to define a global
> flag. Otherwise, you have to select a value carefully which must not be
> defined in ata_port flags already, which way is very error-prone and not
> friendly.
Bits 24:31 of ata_port flags are reserved for driver-specific uses.
Also, this is controller-wide not port-wide, so you can also add
piix_host_priv->flags and use it.
> Anyway, I have not see obvious drawbacks to define a global ata_port
> flag.
Sergei is right here. Please move it to driver specific flags. If we
end up doing this for multiple controllers, then we can move the flag
(and handling of it too) to generic code.
Thank you.
--
tejun
next prev parent reply other threads:[~2011-10-06 16:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-01 1:43 [PATCH] ata_piix: make DVD Drive recognisable on systems with Intel Sandybridge chipsets(v1) ming.lei
2011-10-01 4:38 ` Tejun Heo
2011-10-05 9:45 ` Sergei Shtylyov
2011-10-06 9:27 ` Ming Lei
2011-10-06 10:39 ` Sergei Shtylyov
2011-10-06 11:53 ` Ming Lei
2011-10-06 14:06 ` Sergei Shtylyov
2011-10-06 16:54 ` Tejun Heo [this message]
2011-10-07 3:31 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111006165437.GA3953@google.com \
--to=htejun@gmail.com \
--cc=alan@linux.intel.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=seth.heasley@intel.com \
--cc=sshtylyov@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).