From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH] icside: DMA support fix Date: Wed, 12 Oct 2011 16:45:34 +0200 Message-ID: <201110121645.47490.bzolnier@gmail.com> References: <201110111933.48430.bzolnier@gmail.com> <20111011.145523.1844316617273586111.davem@davemloft.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ey0-f174.google.com ([209.85.215.174]:46008 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751880Ab1JLOwm (ORCPT ); Wed, 12 Oct 2011 10:52:42 -0400 In-Reply-To: <20111011.145523.1844316617273586111.davem@davemloft.net> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: David Miller Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org David Miller wrote: > From: Bartlomiej Zolnierkiewicz > Date: Tue, 11 Oct 2011 19:33:48 +0200 > > > From: Bartlomiej Zolnierkiewicz > > Subject: [PATCH] icside: DMA support fix > > > > Signed-off-by: Bartlomiej Zolnierkiewicz > > You're going to have to give me a more verbose commit message than > that. From: Bartlomiej Zolnierkiewicz Subject: [PATCH v2] icside: DMA support fix Fix problem introduced by commit 5e37bdc ("ide: add struct ide_dma_ops (take 3)"): d.dma_ops shouldn't be cleared if we are going to use DMA. Signed-off-by: Bartlomiej Zolnierkiewicz --- v2: updated patch description drivers/ide/icside.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: b/drivers/ide/icside.c =================================================================== --- a/drivers/ide/icside.c +++ b/drivers/ide/icside.c @@ -521,8 +521,8 @@ icside_register_v6(struct icside_state * if (ec->dma != NO_DMA && !request_dma(ec->dma, DRV_NAME)) { d.init_dma = icside_dma_init; d.port_ops = &icside_v6_port_ops; + } else d.dma_ops = NULL; - } ret = ide_host_register(host, &d, hws); if (ret)