* [PATCH] icside: DMA support fix
@ 2011-10-11 17:33 Bartlomiej Zolnierkiewicz
2011-10-11 18:55 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2011-10-11 17:33 UTC (permalink / raw)
To: David Miller; +Cc: linux-ide, linux-kernel
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: [PATCH] icside: DMA support fix
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
drivers/ide/icside.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: b/drivers/ide/icside.c
===================================================================
--- a/drivers/ide/icside.c
+++ b/drivers/ide/icside.c
@@ -521,8 +521,8 @@ icside_register_v6(struct icside_state *
if (ec->dma != NO_DMA && !request_dma(ec->dma, DRV_NAME)) {
d.init_dma = icside_dma_init;
d.port_ops = &icside_v6_port_ops;
+ } else
d.dma_ops = NULL;
- }
ret = ide_host_register(host, &d, hws);
if (ret)
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] icside: DMA support fix
2011-10-11 17:33 [PATCH] icside: DMA support fix Bartlomiej Zolnierkiewicz
@ 2011-10-11 18:55 ` David Miller
2011-10-12 14:45 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2011-10-11 18:55 UTC (permalink / raw)
To: bzolnier; +Cc: linux-ide, linux-kernel
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Date: Tue, 11 Oct 2011 19:33:48 +0200
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] icside: DMA support fix
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
You're going to have to give me a more verbose commit message than
that.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] icside: DMA support fix
2011-10-11 18:55 ` David Miller
@ 2011-10-12 14:45 ` Bartlomiej Zolnierkiewicz
2011-10-13 21:05 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2011-10-12 14:45 UTC (permalink / raw)
To: David Miller; +Cc: linux-ide, linux-kernel
David Miller wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Date: Tue, 11 Oct 2011 19:33:48 +0200
>
> > From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> > Subject: [PATCH] icside: DMA support fix
> >
> > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
>
> You're going to have to give me a more verbose commit message than
> that.
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: [PATCH v2] icside: DMA support fix
Fix problem introduced by commit 5e37bdc ("ide: add struct
ide_dma_ops (take 3)"): d.dma_ops shouldn't be cleared if
we are going to use DMA.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
v2: updated patch description
drivers/ide/icside.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: b/drivers/ide/icside.c
===================================================================
--- a/drivers/ide/icside.c
+++ b/drivers/ide/icside.c
@@ -521,8 +521,8 @@ icside_register_v6(struct icside_state *
if (ec->dma != NO_DMA && !request_dma(ec->dma, DRV_NAME)) {
d.init_dma = icside_dma_init;
d.port_ops = &icside_v6_port_ops;
+ } else
d.dma_ops = NULL;
- }
ret = ide_host_register(host, &d, hws);
if (ret)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-10-13 21:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-11 17:33 [PATCH] icside: DMA support fix Bartlomiej Zolnierkiewicz
2011-10-11 18:55 ` David Miller
2011-10-12 14:45 ` Bartlomiej Zolnierkiewicz
2011-10-13 21:05 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).