From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Jeff Garzik <jgarzik@pobox.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pata_cs5520: remove incorrect warning message
Date: Wed, 12 Oct 2011 17:27:46 +0200 [thread overview]
Message-ID: <201110121727.46778.bzolnier@gmail.com> (raw)
In-Reply-To: <20111011205616.15d0b3b3@lxorguk.ukuu.org.uk>
Alan Cox wrote:
> On Tue, 11 Oct 2011 20:00:44 +0200
> Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote:
>
> > From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> > Subject: [PATCH] pata_cs5520: remove incorrect warning message
> >
> > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
>
> Nothing incorrect about it. It's rather useful information for debugging
> CS5520 problems. Users should never see it - and I've not seen it
> occuring on any standard VSA releases.
>
> Do you have any examples of it confusing users or even showing up ?
This driver dooen't even use DMA mode so warning about forcing the setting
may be puzzling. In addition we do the same thing cs5520_reinit_one()
but without warning the user this time. Thus removal of the warning makes
it easier for *_reinit_one() replacement by ->init_host method later
(patch is ready for this).
next prev parent reply other threads:[~2011-10-12 15:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-11 18:00 [PATCH] pata_cs5520: remove incorrect warning message Bartlomiej Zolnierkiewicz
2011-10-11 19:56 ` Alan Cox
2011-10-12 15:27 ` Bartlomiej Zolnierkiewicz [this message]
2011-10-12 17:50 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110121727.46778.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).