* [PATCH 2/2] pata_oldpiix: enable parallel scan
@ 2011-10-13 14:03 Bartlomiej Zolnierkiewicz
2011-10-13 15:47 ` Alan Cox
0 siblings, 1 reply; 4+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2011-10-13 14:03 UTC (permalink / raw)
To: Jeff Garzik; +Cc: linux-ide, linux-kernel
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: [PATCH] pata_oldpiix: enable parallel scan
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
earlier references:
https://lkml.org/lkml/2011/2/8/111
https://lkml.org/lkml/2010/2/18/275
drivers/ata/pata_oldpiix.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: b/drivers/ata/pata_oldpiix.c
===================================================================
--- a/drivers/ata/pata_oldpiix.c
+++ b/drivers/ata/pata_oldpiix.c
@@ -258,7 +258,8 @@ static int oldpiix_init_one (struct pci_
ata_print_version_once(&pdev->dev, DRV_VERSION);
- return ata_pci_bmdma_init_one(pdev, ppi, &oldpiix_sht, NULL, 0);
+ return ata_pci_bmdma_init_one(pdev, ppi, &oldpiix_sht, NULL,
+ ATA_HOST_PARALLEL_SCAN);
}
static const struct pci_device_id oldpiix_pci_tbl[] = {
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 2/2] pata_oldpiix: enable parallel scan
2011-10-13 14:03 [PATCH 2/2] pata_oldpiix: enable parallel scan Bartlomiej Zolnierkiewicz
@ 2011-10-13 15:47 ` Alan Cox
2011-10-13 16:06 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 4+ messages in thread
From: Alan Cox @ 2011-10-13 15:47 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: Jeff Garzik, linux-ide, linux-kernel
On Thu, 13 Oct 2011 16:03:34 +0200
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] pata_oldpiix: enable parallel scan
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Have you tested this. When I talked with Intel people about parallel
scanning nobody in Intel I could find could answer whether it was safe on
the ancient PIIX versions.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] pata_oldpiix: enable parallel scan
2011-10-13 15:47 ` Alan Cox
@ 2011-10-13 16:06 ` Bartlomiej Zolnierkiewicz
2011-10-13 19:12 ` Alan Cox
0 siblings, 1 reply; 4+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2011-10-13 16:06 UTC (permalink / raw)
To: Alan Cox; +Cc: Jeff Garzik, linux-ide, linux-kernel
Alan Cox wrote:
> On Thu, 13 Oct 2011 16:03:34 +0200
> Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote:
>
> > From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> > Subject: [PATCH] pata_oldpiix: enable parallel scan
> >
> > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
>
> Have you tested this. When I talked with Intel people about parallel
> scanning nobody in Intel I could find could answer whether it was safe on
> the ancient PIIX versions.
No, it wasn't tested on the real hardware.
I think it should be in libata-dev or -mm/-next for rather long time..
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] pata_oldpiix: enable parallel scan
2011-10-13 16:06 ` Bartlomiej Zolnierkiewicz
@ 2011-10-13 19:12 ` Alan Cox
0 siblings, 0 replies; 4+ messages in thread
From: Alan Cox @ 2011-10-13 19:12 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: Jeff Garzik, linux-ide, linux-kernel
On Thu, 13 Oct 2011 18:06:08 +0200
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote:
> Alan Cox wrote:
>
> > On Thu, 13 Oct 2011 16:03:34 +0200
> > Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote:
> >
> > > From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> > > Subject: [PATCH] pata_oldpiix: enable parallel scan
> > >
> > > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> >
> > Have you tested this. When I talked with Intel people about parallel
> > scanning nobody in Intel I could find could answer whether it was safe on
> > the ancient PIIX versions.
>
> No, it wasn't tested on the real hardware.
>
> I think it should be in libata-dev or -mm/-next for rather long time..
I don't see it's worth adding, its near impossible to test and its for
old hardware that doesn't fast boot anyway. Really it's the netbook
generation devices where this matters.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-10-13 19:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-13 14:03 [PATCH 2/2] pata_oldpiix: enable parallel scan Bartlomiej Zolnierkiewicz
2011-10-13 15:47 ` Alan Cox
2011-10-13 16:06 ` Bartlomiej Zolnierkiewicz
2011-10-13 19:12 ` Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).