From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
Gwendal Grignou ` <gwendal@google.com>,
Grant Grundler <grundler@google.com>
Subject: Re: [PATCH] libata: fix for transport xfer attributes
Date: Fri, 14 Oct 2011 11:58:33 +0200 [thread overview]
Message-ID: <201110141158.33983.bzolnier@gmail.com> (raw)
In-Reply-To: <4E9762DE.1060009@pobox.com>
Jeff Garzik wrote:
> On 10/13/2011 04:03 PM, Bartlomiej Zolnierkiewicz wrote:
> > From: Bartlomiej Zolnierkiewicz<bzolnier@gmail.com>
> > Subject: [PATCH] libata: fix for transport xfer attributes
> >
> > Fix display of pio_mode, dma_mode and xfer_mode device attributes.
> >
> > before:
> > $ cat /sys/class/ata_device/dev1.0/xfer_mode
> > XFER_UDMA_7, XFER_UDMA_6, XFER_UDMA_5, XFER_UDMA_4, XFER_UDMA_3, XFER_UDMA_2, XF
> > ER_UDMA_1, XFER_UDMA_0, XFER_MW_DMA_4, XFER_MW_DMA_3, XFER_MW_DMA_2, XFER_SW_DMA
> > _2, XFER_PIO_6, XFER_PIO_5, XFER_PIO_4, XFER_PIO_3, XFER_PIO_2
> >
> > after:
> > $ cat /sys/class/ata_device/dev1.0/xfer_mode
> > XFER_UDMA_6
> >
> > Signed-off-by: Bartlomiej Zolnierkiewicz<bzolnier@gmail.com>
> > ---
> > Documentation/ABI/testing/sysfs-ata | 4 ++--
> > drivers/ata/libata-transport.c | 2 +-
> > 2 files changed, 3 insertions(+), 3 deletions(-)
> >
> > Index: b/Documentation/ABI/testing/sysfs-ata
> > ===================================================================
> > --- a/Documentation/ABI/testing/sysfs-ata
> > +++ b/Documentation/ABI/testing/sysfs-ata
> > @@ -59,12 +59,12 @@ class
> >
> > dma_mode
> >
> > - Transfer modes supported by the device when in DMA mode.
> > + Transfer mode currently used by the device when in DMA mode.
> > Mostly used by PATA device.
> >
> > pio_mode
> >
> > - Transfer modes supported by the device when in PIO mode.
> > + Transfer mode currently used by the device when in PIO mode.
> > Mostly used by PATA device.
> >
> > xfer_mode
> > Index: b/drivers/ata/libata-transport.c
> > ===================================================================
> > --- a/drivers/ata/libata-transport.c
> > +++ b/drivers/ata/libata-transport.c
> > @@ -194,7 +194,7 @@ static struct {
> > { XFER_PIO_0, "XFER_PIO_0" },
> > { XFER_PIO_SLOW, "XFER_PIO_SLOW" }
> > };
> > -ata_bitfield_name_match(xfer,ata_xfer_names)
> > +ata_bitfield_name_search(xfer, ata_xfer_names)
>
> "fix" or not it is an ABI change... who is impacted? Has anyone used
> the current, pre-patch behavior as documented?
I doubt that anyone has used it given the current incorrect behavior but lets
ask libata transport authors..
next prev parent reply other threads:[~2011-10-14 9:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-13 20:03 [PATCH] libata: fix for transport xfer attributes Bartlomiej Zolnierkiewicz
2011-10-13 22:14 ` Jeff Garzik
2011-10-14 9:58 ` Bartlomiej Zolnierkiewicz [this message]
2011-10-14 19:12 ` Grant Grundler
2011-10-14 19:31 ` Alan Cox
2011-10-19 23:46 ` Gwendal Grignou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110141158.33983.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=grundler@google.com \
--cc=gwendal@google.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).