* [PATCH] libata: fix for transport xfer attributes
@ 2011-10-13 20:03 Bartlomiej Zolnierkiewicz
2011-10-13 22:14 ` Jeff Garzik
0 siblings, 1 reply; 6+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2011-10-13 20:03 UTC (permalink / raw)
To: Jeff Garzik; +Cc: linux-ide, linux-kernel
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: [PATCH] libata: fix for transport xfer attributes
Fix display of pio_mode, dma_mode and xfer_mode device attributes.
before:
$ cat /sys/class/ata_device/dev1.0/xfer_mode
XFER_UDMA_7, XFER_UDMA_6, XFER_UDMA_5, XFER_UDMA_4, XFER_UDMA_3, XFER_UDMA_2, XF
ER_UDMA_1, XFER_UDMA_0, XFER_MW_DMA_4, XFER_MW_DMA_3, XFER_MW_DMA_2, XFER_SW_DMA
_2, XFER_PIO_6, XFER_PIO_5, XFER_PIO_4, XFER_PIO_3, XFER_PIO_2
after:
$ cat /sys/class/ata_device/dev1.0/xfer_mode
XFER_UDMA_6
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
Documentation/ABI/testing/sysfs-ata | 4 ++--
drivers/ata/libata-transport.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
Index: b/Documentation/ABI/testing/sysfs-ata
===================================================================
--- a/Documentation/ABI/testing/sysfs-ata
+++ b/Documentation/ABI/testing/sysfs-ata
@@ -59,12 +59,12 @@ class
dma_mode
- Transfer modes supported by the device when in DMA mode.
+ Transfer mode currently used by the device when in DMA mode.
Mostly used by PATA device.
pio_mode
- Transfer modes supported by the device when in PIO mode.
+ Transfer mode currently used by the device when in PIO mode.
Mostly used by PATA device.
xfer_mode
Index: b/drivers/ata/libata-transport.c
===================================================================
--- a/drivers/ata/libata-transport.c
+++ b/drivers/ata/libata-transport.c
@@ -194,7 +194,7 @@ static struct {
{ XFER_PIO_0, "XFER_PIO_0" },
{ XFER_PIO_SLOW, "XFER_PIO_SLOW" }
};
-ata_bitfield_name_match(xfer,ata_xfer_names)
+ata_bitfield_name_search(xfer, ata_xfer_names)
/*
* ATA Port attributes
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] libata: fix for transport xfer attributes
2011-10-13 20:03 [PATCH] libata: fix for transport xfer attributes Bartlomiej Zolnierkiewicz
@ 2011-10-13 22:14 ` Jeff Garzik
2011-10-14 9:58 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 6+ messages in thread
From: Jeff Garzik @ 2011-10-13 22:14 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: linux-ide, linux-kernel
On 10/13/2011 04:03 PM, Bartlomiej Zolnierkiewicz wrote:
> From: Bartlomiej Zolnierkiewicz<bzolnier@gmail.com>
> Subject: [PATCH] libata: fix for transport xfer attributes
>
> Fix display of pio_mode, dma_mode and xfer_mode device attributes.
>
> before:
> $ cat /sys/class/ata_device/dev1.0/xfer_mode
> XFER_UDMA_7, XFER_UDMA_6, XFER_UDMA_5, XFER_UDMA_4, XFER_UDMA_3, XFER_UDMA_2, XF
> ER_UDMA_1, XFER_UDMA_0, XFER_MW_DMA_4, XFER_MW_DMA_3, XFER_MW_DMA_2, XFER_SW_DMA
> _2, XFER_PIO_6, XFER_PIO_5, XFER_PIO_4, XFER_PIO_3, XFER_PIO_2
>
> after:
> $ cat /sys/class/ata_device/dev1.0/xfer_mode
> XFER_UDMA_6
>
> Signed-off-by: Bartlomiej Zolnierkiewicz<bzolnier@gmail.com>
> ---
> Documentation/ABI/testing/sysfs-ata | 4 ++--
> drivers/ata/libata-transport.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> Index: b/Documentation/ABI/testing/sysfs-ata
> ===================================================================
> --- a/Documentation/ABI/testing/sysfs-ata
> +++ b/Documentation/ABI/testing/sysfs-ata
> @@ -59,12 +59,12 @@ class
>
> dma_mode
>
> - Transfer modes supported by the device when in DMA mode.
> + Transfer mode currently used by the device when in DMA mode.
> Mostly used by PATA device.
>
> pio_mode
>
> - Transfer modes supported by the device when in PIO mode.
> + Transfer mode currently used by the device when in PIO mode.
> Mostly used by PATA device.
>
> xfer_mode
> Index: b/drivers/ata/libata-transport.c
> ===================================================================
> --- a/drivers/ata/libata-transport.c
> +++ b/drivers/ata/libata-transport.c
> @@ -194,7 +194,7 @@ static struct {
> { XFER_PIO_0, "XFER_PIO_0" },
> { XFER_PIO_SLOW, "XFER_PIO_SLOW" }
> };
> -ata_bitfield_name_match(xfer,ata_xfer_names)
> +ata_bitfield_name_search(xfer, ata_xfer_names)
"fix" or not it is an ABI change... who is impacted? Has anyone used
the current, pre-patch behavior as documented?
Jeff
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] libata: fix for transport xfer attributes
2011-10-13 22:14 ` Jeff Garzik
@ 2011-10-14 9:58 ` Bartlomiej Zolnierkiewicz
2011-10-14 19:12 ` Grant Grundler
0 siblings, 1 reply; 6+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2011-10-14 9:58 UTC (permalink / raw)
To: Jeff Garzik; +Cc: linux-ide, linux-kernel, Gwendal Grignou `, Grant Grundler
Jeff Garzik wrote:
> On 10/13/2011 04:03 PM, Bartlomiej Zolnierkiewicz wrote:
> > From: Bartlomiej Zolnierkiewicz<bzolnier@gmail.com>
> > Subject: [PATCH] libata: fix for transport xfer attributes
> >
> > Fix display of pio_mode, dma_mode and xfer_mode device attributes.
> >
> > before:
> > $ cat /sys/class/ata_device/dev1.0/xfer_mode
> > XFER_UDMA_7, XFER_UDMA_6, XFER_UDMA_5, XFER_UDMA_4, XFER_UDMA_3, XFER_UDMA_2, XF
> > ER_UDMA_1, XFER_UDMA_0, XFER_MW_DMA_4, XFER_MW_DMA_3, XFER_MW_DMA_2, XFER_SW_DMA
> > _2, XFER_PIO_6, XFER_PIO_5, XFER_PIO_4, XFER_PIO_3, XFER_PIO_2
> >
> > after:
> > $ cat /sys/class/ata_device/dev1.0/xfer_mode
> > XFER_UDMA_6
> >
> > Signed-off-by: Bartlomiej Zolnierkiewicz<bzolnier@gmail.com>
> > ---
> > Documentation/ABI/testing/sysfs-ata | 4 ++--
> > drivers/ata/libata-transport.c | 2 +-
> > 2 files changed, 3 insertions(+), 3 deletions(-)
> >
> > Index: b/Documentation/ABI/testing/sysfs-ata
> > ===================================================================
> > --- a/Documentation/ABI/testing/sysfs-ata
> > +++ b/Documentation/ABI/testing/sysfs-ata
> > @@ -59,12 +59,12 @@ class
> >
> > dma_mode
> >
> > - Transfer modes supported by the device when in DMA mode.
> > + Transfer mode currently used by the device when in DMA mode.
> > Mostly used by PATA device.
> >
> > pio_mode
> >
> > - Transfer modes supported by the device when in PIO mode.
> > + Transfer mode currently used by the device when in PIO mode.
> > Mostly used by PATA device.
> >
> > xfer_mode
> > Index: b/drivers/ata/libata-transport.c
> > ===================================================================
> > --- a/drivers/ata/libata-transport.c
> > +++ b/drivers/ata/libata-transport.c
> > @@ -194,7 +194,7 @@ static struct {
> > { XFER_PIO_0, "XFER_PIO_0" },
> > { XFER_PIO_SLOW, "XFER_PIO_SLOW" }
> > };
> > -ata_bitfield_name_match(xfer,ata_xfer_names)
> > +ata_bitfield_name_search(xfer, ata_xfer_names)
>
> "fix" or not it is an ABI change... who is impacted? Has anyone used
> the current, pre-patch behavior as documented?
I doubt that anyone has used it given the current incorrect behavior but lets
ask libata transport authors..
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] libata: fix for transport xfer attributes
2011-10-14 9:58 ` Bartlomiej Zolnierkiewicz
@ 2011-10-14 19:12 ` Grant Grundler
2011-10-14 19:31 ` Alan Cox
0 siblings, 1 reply; 6+ messages in thread
From: Grant Grundler @ 2011-10-14 19:12 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: Jeff Garzik, linux-ide, linux-kernel, Gwendal Grignou `
On Fri, Oct 14, 2011 at 2:58 AM, Bartlomiej Zolnierkiewicz
<bzolnier@gmail.com> wrote:
...
>> "fix" or not it is an ABI change... who is impacted? Has anyone used
>> the current, pre-patch behavior as documented?
>
> I doubt that anyone has used it given the current incorrect behavior but lets
> ask libata transport authors..
Gwendal is the primary author.
I'm not aware of any uses either.
Based on this kernel.org documentation:
http://www.kernel.org/doc/Documentation/ABI/testing/sysfs-ata
"xfer_mode Current transfer mode."
I agree with Bartomiej that current behavior is incorrect.
cheers,
grant
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] libata: fix for transport xfer attributes
2011-10-14 19:12 ` Grant Grundler
@ 2011-10-14 19:31 ` Alan Cox
2011-10-19 23:46 ` Gwendal Grignou
0 siblings, 1 reply; 6+ messages in thread
From: Alan Cox @ 2011-10-14 19:31 UTC (permalink / raw)
To: Grant Grundler
Cc: Bartlomiej Zolnierkiewicz, Jeff Garzik, linux-ide, linux-kernel,
Gwendal Grignou `
> "xfer_mode Current transfer mode."
>
> I agree with Bartomiej that current behavior is incorrect.
Well we should probably fix the document and add the current transfer
mode as its own sysfs entry - much less risky.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] libata: fix for transport xfer attributes
2011-10-14 19:31 ` Alan Cox
@ 2011-10-19 23:46 ` Gwendal Grignou
0 siblings, 0 replies; 6+ messages in thread
From: Gwendal Grignou @ 2011-10-19 23:46 UTC (permalink / raw)
To: Alan Cox, Bartlomiej Zolnierkiewicz
Cc: Grant Grundler, Jeff Garzik, linux-ide, linux-kernel
Changes looks good. I will post another one related to sata speed
soon. Also, I have to support slave ATA devices.
Gwendal.
On Fri, Oct 14, 2011 at 12:31 PM, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
>> "xfer_mode Current transfer mode."
>>
>> I agree with Bartomiej that current behavior is incorrect.
>
> Well we should probably fix the document and add the current transfer
> mode as its own sysfs entry - much less risky.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ide" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-10-19 23:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-13 20:03 [PATCH] libata: fix for transport xfer attributes Bartlomiej Zolnierkiewicz
2011-10-13 22:14 ` Jeff Garzik
2011-10-14 9:58 ` Bartlomiej Zolnierkiewicz
2011-10-14 19:12 ` Grant Grundler
2011-10-14 19:31 ` Alan Cox
2011-10-19 23:46 ` Gwendal Grignou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).