linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Paul Schilling <paul.s.schilling@gmail.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jesse Barnes <jbarnes@virtuousgeek.org>,
	linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-pci@vger.kernel.org
Subject: Re: [PATCH 02/15] ATA : vortex86 : fix vortex86dx/sx hardware CRC bug.
Date: Thu, 27 Oct 2011 08:43:10 +0100	[thread overview]
Message-ID: <20111027084310.2b7da753@pyx> (raw)
In-Reply-To: <1319602564-19162-1-git-send-email-paul.s.schilling@gmail.com>

On Tue, 25 Oct 2011 23:16:04 -0500
Paul Schilling <paul.s.schilling@gmail.com> wrote:

> This fixes a DMA issue related to a CRC bug on
> the RDC pata peripherial found on the vortex86sx and vortex86dx.

What is the RDC erratum reference for this ? Also it seems to make no
sense


>  	static const struct ata_port_info info_rdc_11 = {
>  		.flags = ATA_FLAG_SLAVE_POSS,
>  		.pio_mask = ATA_PIO4,
> -		.mwdma_mask = ATA_MWDMA2,
> +		.mwdma_mask = 0,
> +		.udma_mask = 0,

MWDMA is not part of the CRC hardware anyway

Are you sure these newer variants are simply not using a different set of
timing parameters thus showing bugs on your system ?

  reply	other threads:[~2011-10-27  7:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <fix vortex86>
2011-10-23  5:05 ` [PATCH 02/15] ATA : vortex86 : fix vortex86dx/sx hardware CRC bug Paul Schilling
2011-10-23  8:20   ` Rolf Eike Beer
2011-10-23 16:26     ` Paul Schilling
2011-10-26  4:16 ` Paul Schilling
2011-10-27  7:43   ` Alan Cox [this message]
2011-10-27 18:55     ` Paul Schilling
2011-10-27 19:03       ` Paul Schilling
2011-10-28 18:27       ` Alan Cox
2011-10-31 19:07     ` Paul Schilling
2011-11-01  1:02       ` Alan Cox
2011-11-03 22:58         ` Paul Schilling
2011-11-03 23:19           ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111027084310.2b7da753@pyx \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=davem@davemloft.net \
    --cc=jbarnes@virtuousgeek.org \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=paul.s.schilling@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).