* [PATCH 02/15] ATA : vortex86 : fix vortex86dx/sx hardware CRC bug. [not found] <fix vortex86> @ 2011-10-23 5:05 ` Paul Schilling 2011-10-23 8:20 ` Rolf Eike Beer 2011-10-26 4:16 ` Paul Schilling 1 sibling, 1 reply; 12+ messages in thread From: Paul Schilling @ 2011-10-23 5:05 UTC (permalink / raw) To: Jeff Garzik, David S. Miller, Jesse Barnes, linux-ide, linux-kernel, linux-pci@ Cc: Paul Schilling, Paul Schilling This fixes a DMA issue related to a CRC bug on the RDC pata peripherial found on the vortex86sx and vortex86dx. Signed-off-by: Paul Schilling <paul.s.schilling@gmail.com> --- drivers/ata/pata_it821x.c | 22 ++++++++++++++++++---- drivers/ata/pata_rdc.c | 29 ++++++++++++++++++++++++----- drivers/ide/it821x.c | 9 +++++++-- include/linux/pci_ids.h | 2 ++ 4 files changed, 51 insertions(+), 11 deletions(-) diff --git a/drivers/ata/pata_it821x.c b/drivers/ata/pata_it821x.c index c5532b9..5f8a54a 100644 --- a/drivers/ata/pata_it821x.c +++ b/drivers/ata/pata_it821x.c @@ -897,7 +897,16 @@ static int it821x_init_one(struct pci_dev *pdev, const struct pci_device_id *id) static const struct ata_port_info info_rdc_11 = { .flags = ATA_FLAG_SLAVE_POSS, .pio_mask = ATA_PIO4, - .mwdma_mask = ATA_MWDMA2, + .mwdma_mask = 0, + .udma_mask = 0, + /* No UDMA */ + .port_ops = &it821x_rdc_port_ops + }; + static const struct ata_port_info info_rdc_01 = { + .flags = ATA_FLAG_SLAVE_POSS, + .pio_mask = ATA_PIO4, + .mwdma_mask = 0, + .udma_mask = 0, /* No UDMA */ .port_ops = &it821x_rdc_port_ops }; @@ -911,11 +920,16 @@ static int it821x_init_one(struct pci_dev *pdev, const struct pci_device_id *id) return rc; if (pdev->vendor == PCI_VENDOR_ID_RDC) { - /* Deal with Vortex86SX */ - if (pdev->revision == 0x11) + if (((pdev->revision == 0x11) || (pdev->revision == 0x13)) && + (pdev->device == PCI_DEVICE_ID_RDC_D1010)) { + /* Deal with Vortex86SX */ ppi[0] = &info_rdc_11; - else + printk(KERN_INFO DRV_NAME + ": Detected Vortex86SX/DX Bug.\n"); + printk(KERN_INFO DRV_NAME ": Disabling UDMA.\n"); + } else { ppi[0] = &info_rdc; + } } else { /* Force the card into bypass mode if so requested */ if (it8212_noraid) { diff --git a/drivers/ata/pata_rdc.c b/drivers/ata/pata_rdc.c index 2b38127..441521c 100644 --- a/drivers/ata/pata_rdc.c +++ b/drivers/ata/pata_rdc.c @@ -290,6 +290,16 @@ static struct ata_port_info rdc_port_info = { .port_ops = &rdc_pata_ops, }; +static struct ata_port_info vortex_port_info = { + .flags = ATA_FLAG_SLAVE_POSS, + .pio_mask = ATA_PIO4, + .mwdma_mask = 0, + .udma_mask = 0, + /* No UDMA */ + .port_ops = &rdc_pata_ops, +}; + + static struct scsi_host_template rdc_sht = { ATA_BMDMA_SHT(DRV_NAME), }; @@ -322,16 +332,25 @@ static int __devinit rdc_init_one(struct pci_dev *pdev, ata_print_version_once(&pdev->dev, DRV_VERSION); - port_info[0] = rdc_port_info; - port_info[1] = rdc_port_info; - - port_flags = port_info[0].flags; - /* enable device and prepare host */ rc = pcim_enable_device(pdev); if (rc) return rc; + if ((pdev->revision == 0x01) && + (pdev->device == PCI_DEVICE_ID_RDC_D1011)) { + /* Deal with Vortex86DX */ + port_info[0] = vortex_port_info; + port_info[1] = vortex_port_info; + printk(KERN_INFO DRV_NAME ": Detected Vortex86DX Bug.\n"); + printk(KERN_INFO DRV_NAME ": Disabling UDMA.\n"); + } else { + port_info[0] = rdc_port_info; + port_info[1] = rdc_port_info; + } + + port_flags = port_info[0].flags; + hpriv = devm_kzalloc(dev, sizeof(*hpriv), GFP_KERNEL); if (!hpriv) return -ENOMEM; diff --git a/drivers/ide/it821x.c b/drivers/ide/it821x.c index 2e3169f..82c6bc7 100644 --- a/drivers/ide/it821x.c +++ b/drivers/ide/it821x.c @@ -581,10 +581,14 @@ static void __devinit init_hwif_it821x(ide_hwif_t *hwif) hwif->ultra_mask = ATA_UDMA6; hwif->mwdma_mask = ATA_MWDMA2; - /* Vortex86SX quirk: prevent Ultra-DMA mode to fix BadCRC issue */ + /* Vortex86SX and Vortex86DX quirk: prevent + * Ultra-DMA mode to fix BadCRC issue when + * using DMA mode */ if (idev->quirks & QUIRK_VORTEX86) { - if (dev->revision == 0x11) + if (((dev->revision == 0x11) || (dev->revision == 0x13)) + || (dev->revision == 0x01)) { hwif->ultra_mask = 0; + } } } @@ -680,6 +684,7 @@ static const struct pci_device_id it821x_pci_tbl[] = { { PCI_VDEVICE(ITE, PCI_DEVICE_ID_ITE_8211), 0 }, { PCI_VDEVICE(ITE, PCI_DEVICE_ID_ITE_8212), 0 }, { PCI_VDEVICE(RDC, PCI_DEVICE_ID_RDC_D1010), QUIRK_VORTEX86 }, + { PCI_VDEVICE(RDC, PCI_DEVICE_ID_RDC_D1011), QUIRK_VORTEX86 }, { 0, }, }; diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index ae96bbe..237da92 100644 --- a/include/linux/pci_ids.h +++ b/include/linux/pci_ids.h @@ -2259,6 +2259,8 @@ #define PCI_DEVICE_ID_RDC_R6060 0x6060 #define PCI_DEVICE_ID_RDC_R6061 0x6061 #define PCI_DEVICE_ID_RDC_D1010 0x1010 +#define PCI_DEVICE_ID_RDC_D1011 0x1011 +#define PCI_DEVICE_ID_RDC_D1012 0x1012 #define PCI_VENDOR_ID_LENOVO 0x17aa -- 1.7.6.4 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 02/15] ATA : vortex86 : fix vortex86dx/sx hardware CRC bug. 2011-10-23 5:05 ` [PATCH 02/15] ATA : vortex86 : fix vortex86dx/sx hardware CRC bug Paul Schilling @ 2011-10-23 8:20 ` Rolf Eike Beer 2011-10-23 16:26 ` Paul Schilling 0 siblings, 1 reply; 12+ messages in thread From: Rolf Eike Beer @ 2011-10-23 8:20 UTC (permalink / raw) To: Paul Schilling Cc: Jeff Garzik, David S. Miller, Jesse Barnes, linux-ide, linux-kernel, linux-pci, Paul Schilling [-- Attachment #1: Type: text/plain, Size: 1273 bytes --] Paul Schilling wrote: > This fixes a DMA issue related to a CRC bug on > the RDC pata peripherial found on the vortex86sx and vortex86dx. > > Signed-off-by: Paul Schilling <paul.s.schilling@gmail.com> > --- > drivers/ata/pata_it821x.c | 22 ++++++++++++++++++---- > drivers/ata/pata_rdc.c | 29 ++++++++++++++++++++++++----- > drivers/ide/it821x.c | 9 +++++++-- > include/linux/pci_ids.h | 2 ++ > 4 files changed, 51 insertions(+), 11 deletions(-) > > diff --git a/drivers/ata/pata_it821x.c b/drivers/ata/pata_it821x.c > index c5532b9..5f8a54a 100644 > --- a/drivers/ata/pata_it821x.c > +++ b/drivers/ata/pata_it821x.c > @@ -897,7 +897,16 @@ static int it821x_init_one(struct pci_dev *pdev, const > struct pci_device_id *id) static const struct ata_port_info info_rdc_11 = { > .flags = ATA_FLAG_SLAVE_POSS, > .pio_mask = ATA_PIO4, > - .mwdma_mask = ATA_MWDMA2, > + .mwdma_mask = 0, > + .udma_mask = 0, > + /* No UDMA */ > + .port_ops = &it821x_rdc_port_ops > + }; > + static const struct ata_port_info info_rdc_01 = { > + .flags = ATA_FLAG_SLAVE_POSS, > + .pio_mask = ATA_PIO4, > + .mwdma_mask = 0, > + .udma_mask = 0, > /* No UDMA */ > .port_ops = &it821x_rdc_port_ops > }; Why do you define this if it is never used? Eike [-- Attachment #2: This is a digitally signed message part. --] [-- Type: application/pgp-signature, Size: 198 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 02/15] ATA : vortex86 : fix vortex86dx/sx hardware CRC bug. 2011-10-23 8:20 ` Rolf Eike Beer @ 2011-10-23 16:26 ` Paul Schilling 0 siblings, 0 replies; 12+ messages in thread From: Paul Schilling @ 2011-10-23 16:26 UTC (permalink / raw) To: Rolf Eike Beer Cc: Jeff Garzik, David S. Miller, Jesse Barnes, linux-ide, linux-kernel, linux-pci Thanks, That was a good catch. I had that extra struct for another revision of the RDC peripheral integrated into the Vortex86DX. I removed it when I moved it to the pata_rdc.c driver but forgot the struct. The it821x driver works for the RDC drivers when DMA is turned off. But the RDC driver is the more logical choice. I will make the fix and send out the new patch. I accidentally sent this through the gmail interface with html on, Some of you may get this email twice. Thanks, Paul Schilling On Sun, Oct 23, 2011 at 3:20 AM, Rolf Eike Beer <eike-kernel@sf-tec.de> wrote: > > Paul Schilling wrote: > > This fixes a DMA issue related to a CRC bug on > > the RDC pata peripherial found on the vortex86sx and vortex86dx. > > > > Signed-off-by: Paul Schilling <paul.s.schilling@gmail.com> > > --- > > drivers/ata/pata_it821x.c | 22 ++++++++++++++++++---- > > drivers/ata/pata_rdc.c | 29 ++++++++++++++++++++++++----- > > drivers/ide/it821x.c | 9 +++++++-- > > include/linux/pci_ids.h | 2 ++ > > 4 files changed, 51 insertions(+), 11 deletions(-) > > > > diff --git a/drivers/ata/pata_it821x.c b/drivers/ata/pata_it821x.c > > index c5532b9..5f8a54a 100644 > > --- a/drivers/ata/pata_it821x.c > > +++ b/drivers/ata/pata_it821x.c > > @@ -897,7 +897,16 @@ static int it821x_init_one(struct pci_dev *pdev, const > > struct pci_device_id *id) static const struct ata_port_info info_rdc_11 = { > > .flags = ATA_FLAG_SLAVE_POSS, > > .pio_mask = ATA_PIO4, > > - .mwdma_mask = ATA_MWDMA2, > > + .mwdma_mask = 0, > > + .udma_mask = 0, > > + /* No UDMA */ > > + .port_ops = &it821x_rdc_port_ops > > + }; > > + static const struct ata_port_info info_rdc_01 = { > > + .flags = ATA_FLAG_SLAVE_POSS, > > + .pio_mask = ATA_PIO4, > > + .mwdma_mask = 0, > > + .udma_mask = 0, > > /* No UDMA */ > > .port_ops = &it821x_rdc_port_ops > > }; > > Why do you define this if it is never used? > > Eike ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 02/15] ATA : vortex86 : fix vortex86dx/sx hardware CRC bug. [not found] <fix vortex86> 2011-10-23 5:05 ` [PATCH 02/15] ATA : vortex86 : fix vortex86dx/sx hardware CRC bug Paul Schilling @ 2011-10-26 4:16 ` Paul Schilling 2011-10-27 7:43 ` Alan Cox 1 sibling, 1 reply; 12+ messages in thread From: Paul Schilling @ 2011-10-26 4:16 UTC (permalink / raw) To: Jeff Garzik, David S. Miller, Jesse Barnes, linux-ide, linux-kernel, linux-pci@ Cc: Paul Schilling, Paul Schilling This fixes a DMA issue related to a CRC bug on the RDC pata peripherial found on the vortex86sx and vortex86dx. Signed-off-by: Paul Schilling <paul.s.schilling@gmail.com> --- drivers/ata/pata_it821x.c | 14 ++++++++++---- drivers/ata/pata_rdc.c | 29 ++++++++++++++++++++++++----- drivers/ide/it821x.c | 9 +++++++-- include/linux/pci_ids.h | 2 ++ 4 files changed, 43 insertions(+), 11 deletions(-) diff --git a/drivers/ata/pata_it821x.c b/drivers/ata/pata_it821x.c index c5532b9..72c91f2 100644 --- a/drivers/ata/pata_it821x.c +++ b/drivers/ata/pata_it821x.c @@ -897,7 +897,8 @@ static int it821x_init_one(struct pci_dev *pdev, const struct pci_device_id *id) static const struct ata_port_info info_rdc_11 = { .flags = ATA_FLAG_SLAVE_POSS, .pio_mask = ATA_PIO4, - .mwdma_mask = ATA_MWDMA2, + .mwdma_mask = 0, + .udma_mask = 0, /* No UDMA */ .port_ops = &it821x_rdc_port_ops }; @@ -911,11 +912,16 @@ static int it821x_init_one(struct pci_dev *pdev, const struct pci_device_id *id) return rc; if (pdev->vendor == PCI_VENDOR_ID_RDC) { - /* Deal with Vortex86SX */ - if (pdev->revision == 0x11) + if (((pdev->revision == 0x11) || (pdev->revision == 0x13)) && + (pdev->device == PCI_DEVICE_ID_RDC_D1010)) { + /* Deal with Vortex86SX */ ppi[0] = &info_rdc_11; - else + printk(KERN_INFO DRV_NAME + ": Detected Vortex86SX/DX Bug.\n"); + printk(KERN_INFO DRV_NAME ": Disabling UDMA.\n"); + } else { ppi[0] = &info_rdc; + } } else { /* Force the card into bypass mode if so requested */ if (it8212_noraid) { diff --git a/drivers/ata/pata_rdc.c b/drivers/ata/pata_rdc.c index 2b38127..441521c 100644 --- a/drivers/ata/pata_rdc.c +++ b/drivers/ata/pata_rdc.c @@ -290,6 +290,16 @@ static struct ata_port_info rdc_port_info = { .port_ops = &rdc_pata_ops, }; +static struct ata_port_info vortex_port_info = { + .flags = ATA_FLAG_SLAVE_POSS, + .pio_mask = ATA_PIO4, + .mwdma_mask = 0, + .udma_mask = 0, + /* No UDMA */ + .port_ops = &rdc_pata_ops, +}; + + static struct scsi_host_template rdc_sht = { ATA_BMDMA_SHT(DRV_NAME), }; @@ -322,16 +332,25 @@ static int __devinit rdc_init_one(struct pci_dev *pdev, ata_print_version_once(&pdev->dev, DRV_VERSION); - port_info[0] = rdc_port_info; - port_info[1] = rdc_port_info; - - port_flags = port_info[0].flags; - /* enable device and prepare host */ rc = pcim_enable_device(pdev); if (rc) return rc; + if ((pdev->revision == 0x01) && + (pdev->device == PCI_DEVICE_ID_RDC_D1011)) { + /* Deal with Vortex86DX */ + port_info[0] = vortex_port_info; + port_info[1] = vortex_port_info; + printk(KERN_INFO DRV_NAME ": Detected Vortex86DX Bug.\n"); + printk(KERN_INFO DRV_NAME ": Disabling UDMA.\n"); + } else { + port_info[0] = rdc_port_info; + port_info[1] = rdc_port_info; + } + + port_flags = port_info[0].flags; + hpriv = devm_kzalloc(dev, sizeof(*hpriv), GFP_KERNEL); if (!hpriv) return -ENOMEM; diff --git a/drivers/ide/it821x.c b/drivers/ide/it821x.c index 2e3169f..82c6bc7 100644 --- a/drivers/ide/it821x.c +++ b/drivers/ide/it821x.c @@ -581,10 +581,14 @@ static void __devinit init_hwif_it821x(ide_hwif_t *hwif) hwif->ultra_mask = ATA_UDMA6; hwif->mwdma_mask = ATA_MWDMA2; - /* Vortex86SX quirk: prevent Ultra-DMA mode to fix BadCRC issue */ + /* Vortex86SX and Vortex86DX quirk: prevent + * Ultra-DMA mode to fix BadCRC issue when + * using DMA mode */ if (idev->quirks & QUIRK_VORTEX86) { - if (dev->revision == 0x11) + if (((dev->revision == 0x11) || (dev->revision == 0x13)) + || (dev->revision == 0x01)) { hwif->ultra_mask = 0; + } } } @@ -680,6 +684,7 @@ static const struct pci_device_id it821x_pci_tbl[] = { { PCI_VDEVICE(ITE, PCI_DEVICE_ID_ITE_8211), 0 }, { PCI_VDEVICE(ITE, PCI_DEVICE_ID_ITE_8212), 0 }, { PCI_VDEVICE(RDC, PCI_DEVICE_ID_RDC_D1010), QUIRK_VORTEX86 }, + { PCI_VDEVICE(RDC, PCI_DEVICE_ID_RDC_D1011), QUIRK_VORTEX86 }, { 0, }, }; diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index ae96bbe..237da92 100644 --- a/include/linux/pci_ids.h +++ b/include/linux/pci_ids.h @@ -2259,6 +2259,8 @@ #define PCI_DEVICE_ID_RDC_R6060 0x6060 #define PCI_DEVICE_ID_RDC_R6061 0x6061 #define PCI_DEVICE_ID_RDC_D1010 0x1010 +#define PCI_DEVICE_ID_RDC_D1011 0x1011 +#define PCI_DEVICE_ID_RDC_D1012 0x1012 #define PCI_VENDOR_ID_LENOVO 0x17aa -- 1.7.6.4 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 02/15] ATA : vortex86 : fix vortex86dx/sx hardware CRC bug. 2011-10-26 4:16 ` Paul Schilling @ 2011-10-27 7:43 ` Alan Cox 2011-10-27 18:55 ` Paul Schilling 2011-10-31 19:07 ` Paul Schilling 0 siblings, 2 replies; 12+ messages in thread From: Alan Cox @ 2011-10-27 7:43 UTC (permalink / raw) To: Paul Schilling Cc: Jeff Garzik, David S. Miller, Jesse Barnes, linux-ide, linux-kernel, linux-pci On Tue, 25 Oct 2011 23:16:04 -0500 Paul Schilling <paul.s.schilling@gmail.com> wrote: > This fixes a DMA issue related to a CRC bug on > the RDC pata peripherial found on the vortex86sx and vortex86dx. What is the RDC erratum reference for this ? Also it seems to make no sense > static const struct ata_port_info info_rdc_11 = { > .flags = ATA_FLAG_SLAVE_POSS, > .pio_mask = ATA_PIO4, > - .mwdma_mask = ATA_MWDMA2, > + .mwdma_mask = 0, > + .udma_mask = 0, MWDMA is not part of the CRC hardware anyway Are you sure these newer variants are simply not using a different set of timing parameters thus showing bugs on your system ? ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 02/15] ATA : vortex86 : fix vortex86dx/sx hardware CRC bug. 2011-10-27 7:43 ` Alan Cox @ 2011-10-27 18:55 ` Paul Schilling 2011-10-27 19:03 ` Paul Schilling 2011-10-28 18:27 ` Alan Cox 2011-10-31 19:07 ` Paul Schilling 1 sibling, 2 replies; 12+ messages in thread From: Paul Schilling @ 2011-10-27 18:55 UTC (permalink / raw) To: Alan Cox Cc: Jeff Garzik, David S. Miller, Jesse Barnes, linux-ide, linux-kernel, linux-pci The Vortex86dx uses RDC IDE peripheral integrated into the SOC. The CRC design is broken in the Vortex86dx and sx. The original reference can be found in the Linux kernel itself. The Vortex86sx uses the RDC D1010. The Vortex86dx uses the RDC D1011. Both of which have broken CRC hardware which breaks DMA. The pata_821x.c had the following code in it to handle the RDC hardware used in the Vortex86SX. 4fca377f (Jeff Garzik 2011-02-15 01:13:24 -0500 913) 963e4975 (Alan Cox 2008-07-24 17:16:06 +0100 914) if (pdev->vendor == PCI_VENDOR_ID_RDC) { 4a99d95f (Alan Cox 2009-01-11 19:51:08 +0000 915) /* Deal with Vortex86SX */ 4a99d95f (Alan Cox 2009-01-11 19:51:08 +0000 916) if (pdev->revision == 0x11) 4a99d95f (Alan Cox 2009-01-11 19:51:08 +0000 917) ppi[0] = &info_rdc_11; 4a99d95f (Alan Cox 2009-01-11 19:51:08 +0000 918) else 4a99d95f (Alan Cox 2009-01-11 19:51:08 +0000 919) ppi[0] = &info_rdc; 963e4975 (Alan Cox 2008-07-24 17:16:06 +0100 920) } else { 963e4975 (Alan Cox 2008-07-24 17:16:06 +0100 921) /* Force the card into bypass mode if so requested */ 963e4975 (Alan Cox 2008-07-24 17:16:06 +0100 922) if (it8212_noraid) { 963e4975 (Alan Cox 2008-07-24 17:16:06 +0100 923) printk(KERN_INFO DRV_NAME ": forcing bypass mode.\n"); 963e4975 (Alan Cox 2008-07-24 17:16:06 +0100 924) it821x_disable_raid(pdev); Thanks, Paul Schilling On Thu, Oct 27, 2011 at 2:43 AM, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote: > On Tue, 25 Oct 2011 23:16:04 -0500 > Paul Schilling <paul.s.schilling@gmail.com> wrote: > >> This fixes a DMA issue related to a CRC bug on >> the RDC pata peripherial found on the vortex86sx and vortex86dx. > > What is the RDC erratum reference for this ? Also it seems to make no > sense > > >> static const struct ata_port_info info_rdc_11 = { >> .flags = ATA_FLAG_SLAVE_POSS, >> .pio_mask = ATA_PIO4, >> - .mwdma_mask = ATA_MWDMA2, >> + .mwdma_mask = 0, >> + .udma_mask = 0, > > MWDMA is not part of the CRC hardware anyway > > Are you sure these newer variants are simply not using a different set of > timing parameters thus showing bugs on your system ? > ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 02/15] ATA : vortex86 : fix vortex86dx/sx hardware CRC bug. 2011-10-27 18:55 ` Paul Schilling @ 2011-10-27 19:03 ` Paul Schilling 2011-10-28 18:27 ` Alan Cox 1 sibling, 0 replies; 12+ messages in thread From: Paul Schilling @ 2011-10-27 19:03 UTC (permalink / raw) To: Alan Cox Cc: Jeff Garzik, David S. Miller, Jesse Barnes, linux-ide, linux-kernel, linux-pci The Gmail web client wrapped the text on me. Look at line 914 in drivers/ata/pata_it821x.c for references to the Vortex86sx bug. Thanks, Paul On Thu, Oct 27, 2011 at 1:55 PM, Paul Schilling <paul.s.schilling@gmail.com> wrote: > The Vortex86dx uses RDC IDE peripheral integrated into the SOC. The > CRC design is > broken in the Vortex86dx and sx. The original reference can be found > in the Linux kernel itself. > > The Vortex86sx uses the RDC D1010. > The Vortex86dx uses the RDC D1011. > Both of which have broken CRC hardware which breaks DMA. > > The pata_821x.c had the following code in it to handle the RDC > hardware used in the Vortex86SX. > > 4fca377f (Jeff Garzik 2011-02-15 01:13:24 -0500 913) > 963e4975 (Alan Cox 2008-07-24 17:16:06 +0100 914) > if (pdev->vendor == PCI_VENDOR_ID_RDC) { > 4a99d95f (Alan Cox 2009-01-11 19:51:08 +0000 915) > /* Deal with Vortex86SX */ > 4a99d95f (Alan Cox 2009-01-11 19:51:08 +0000 916) > if (pdev->revision == 0x11) > 4a99d95f (Alan Cox 2009-01-11 19:51:08 +0000 917) > ppi[0] = &info_rdc_11; > 4a99d95f (Alan Cox 2009-01-11 19:51:08 +0000 918) > else > 4a99d95f (Alan Cox 2009-01-11 19:51:08 +0000 919) > ppi[0] = &info_rdc; > 963e4975 (Alan Cox 2008-07-24 17:16:06 +0100 920) } else { > 963e4975 (Alan Cox 2008-07-24 17:16:06 +0100 921) > /* Force the card into bypass mode if so requested */ > 963e4975 (Alan Cox 2008-07-24 17:16:06 +0100 922) > if (it8212_noraid) { > 963e4975 (Alan Cox 2008-07-24 17:16:06 +0100 923) > printk(KERN_INFO DRV_NAME ": forcing bypass > mode.\n"); > 963e4975 (Alan Cox 2008-07-24 17:16:06 +0100 924) > it821x_disable_raid(pdev); > > Thanks, > Paul Schilling > > On Thu, Oct 27, 2011 at 2:43 AM, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote: >> On Tue, 25 Oct 2011 23:16:04 -0500 >> Paul Schilling <paul.s.schilling@gmail.com> wrote: >> >>> This fixes a DMA issue related to a CRC bug on >>> the RDC pata peripherial found on the vortex86sx and vortex86dx. >> >> What is the RDC erratum reference for this ? Also it seems to make no >> sense >> >> >>> static const struct ata_port_info info_rdc_11 = { >>> .flags = ATA_FLAG_SLAVE_POSS, >>> .pio_mask = ATA_PIO4, >>> - .mwdma_mask = ATA_MWDMA2, >>> + .mwdma_mask = 0, >>> + .udma_mask = 0, >> >> MWDMA is not part of the CRC hardware anyway >> >> Are you sure these newer variants are simply not using a different set of >> timing parameters thus showing bugs on your system ? >> > ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 02/15] ATA : vortex86 : fix vortex86dx/sx hardware CRC bug. 2011-10-27 18:55 ` Paul Schilling 2011-10-27 19:03 ` Paul Schilling @ 2011-10-28 18:27 ` Alan Cox 1 sibling, 0 replies; 12+ messages in thread From: Alan Cox @ 2011-10-28 18:27 UTC (permalink / raw) To: Paul Schilling Cc: Jeff Garzik, David S. Miller, Jesse Barnes, linux-ide, linux-kernel, linux-pci On Thu, 27 Oct 2011 13:55:21 -0500 Paul Schilling <paul.s.schilling@gmail.com> wrote: > The Vortex86dx uses RDC IDE peripheral integrated into the SOC. The > CRC design is > broken in the Vortex86dx and sx. The original reference can be found > in the Linux kernel itself. > > The Vortex86sx uses the RDC D1010. > The Vortex86dx uses the RDC D1011. > Both of which have broken CRC hardware which breaks DMA. CRC hardware is only used for *UDMA* yet your change also disabled MWDMA. > >> static const struct ata_port_info info_rdc_11 = { > >> .flags = ATA_FLAG_SLAVE_POSS, > >> .pio_mask = ATA_PIO4, > >> - .mwdma_mask = ATA_MWDMA2, > >> + .mwdma_mask = 0, > >> + .udma_mask = 0, Why ? ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 02/15] ATA : vortex86 : fix vortex86dx/sx hardware CRC bug. 2011-10-27 7:43 ` Alan Cox 2011-10-27 18:55 ` Paul Schilling @ 2011-10-31 19:07 ` Paul Schilling 2011-11-01 1:02 ` Alan Cox 1 sibling, 1 reply; 12+ messages in thread From: Paul Schilling @ 2011-10-31 19:07 UTC (permalink / raw) To: Alan Cox Cc: Jeff Garzik, David S. Miller, Jesse Barnes, linux-ide, linux-kernel, linux-pci Hi, When I developed this patch for the Vortex86dx. I recall trying many combinations of udma and mwdma. At the time I developed it, I came to the conclusion that both udma and mwdma both failed with CRC errors being reported. I am not readily set-up to redo the testing to see if mwdma is indeed also affected by the errata. It will be a couple of weeks before I can re-test this patch on the hardware with mwdma turned on. Thanks, Paul On Thu, Oct 27, 2011 at 2:43 AM, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote: > On Tue, 25 Oct 2011 23:16:04 -0500 > Paul Schilling <paul.s.schilling@gmail.com> wrote: > >> This fixes a DMA issue related to a CRC bug on >> the RDC pata peripherial found on the vortex86sx and vortex86dx. > > What is the RDC erratum reference for this ? Also it seems to make no > sense > > >> static const struct ata_port_info info_rdc_11 = { >> .flags = ATA_FLAG_SLAVE_POSS, >> .pio_mask = ATA_PIO4, >> - .mwdma_mask = ATA_MWDMA2, >> + .mwdma_mask = 0, >> + .udma_mask = 0, > > MWDMA is not part of the CRC hardware anyway > > Are you sure these newer variants are simply not using a different set of > timing parameters thus showing bugs on your system ? > ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 02/15] ATA : vortex86 : fix vortex86dx/sx hardware CRC bug. 2011-10-31 19:07 ` Paul Schilling @ 2011-11-01 1:02 ` Alan Cox 2011-11-03 22:58 ` Paul Schilling 0 siblings, 1 reply; 12+ messages in thread From: Alan Cox @ 2011-11-01 1:02 UTC (permalink / raw) To: Paul Schilling Cc: Jeff Garzik, David S. Miller, Jesse Barnes, linux-ide, linux-kernel, linux-pci On Mon, 31 Oct 2011 14:07:45 -0500 Paul Schilling <paul.s.schilling@gmail.com> wrote: > Hi, > > When I developed this patch for the Vortex86dx. I recall trying many > combinations of udma and mwdma. At the time I developed it, I came > to the conclusion that both udma and mwdma both failed with CRC > errors being reported. MWDMA does not have a CRC so that seems unlikely. If you can re-test and we can figure out what is going on that would be useful. Alan ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 02/15] ATA : vortex86 : fix vortex86dx/sx hardware CRC bug. 2011-11-01 1:02 ` Alan Cox @ 2011-11-03 22:58 ` Paul Schilling 2011-11-03 23:19 ` Alan Cox 0 siblings, 1 reply; 12+ messages in thread From: Paul Schilling @ 2011-11-03 22:58 UTC (permalink / raw) To: Alan Cox Cc: Jeff Garzik, David S. Miller, Jesse Barnes, linux-ide, linux-kernel, linux-pci I found two different versions of the Vortex86DX one with RDC_D1011 and the other RDC_D1012. I tested the RDC_D1012 with the pata_rdc driver with MWDMA2 turned on and this is the error I received. the actual error is near the bottom of the dmesg. I am pretty certain that I received the same error when I used a RDC_D1011 with the ite_821x driver with MWDMA2 turned on. I no longer have access to a Vortex86DX with the RDC_D1011. [ 0.000000] Initializing cgroup subsys cpuset [ 0.000000] Initializing cgroup subsys cpu [ 0.000000] Linux version 3.1.0-vortex (root@erased) (gcc version 4.4.3 (Ubuntu 4.4.3-4ubuntu5) ) #1 PREEMPT Thu Nov 3 14:30:13 CDT 2011 [ 0.000000] CPU: vendor_id 'Vortex86 SoC' unknown, using generic init. [ 0.000000] CPU: Your system may be unstable. [ 0.000000] BIOS-provided physical RAM map: [ 0.000000] BIOS-e820: 0000000000000000 - 000000000009fc00 (usable) [ 0.000000] BIOS-e820: 000000000009fc00 - 00000000000a0000 (reserved) [ 0.000000] BIOS-e820: 00000000000e4000 - 0000000000100000 (reserved) [ 0.000000] BIOS-e820: 0000000000100000 - 0000000020000000 (usable) [ 0.000000] BIOS-e820: 00000000ff000000 - 0000000100000000 (reserved) [ 0.000000] Notice: NX (Execute Disable) protection missing in CPU! [ 0.000000] DMI not present or invalid. [ 0.000000] e820 update range: 0000000000000000 - 0000000000010000 (usable) ==> (reserved) [ 0.000000] e820 remove range: 00000000000a0000 - 0000000000100000 (usable) [ 0.000000] last_pfn = 0x20000 max_arch_pfn = 0x100000 [ 0.000000] initial memory mapped : 0 - 00c00000 [ 0.000000] Base memory trampoline at [c009c000] 9c000 size 12288 [ 0.000000] init_memory_mapping: 0000000000000000-0000000020000000 [ 0.000000] 0000000000 - 0020000000 page 4k [ 0.000000] kernel direct mapping tables up to 20000000 @ b7d000-c00000 [ 0.000000] RAMDISK: 17b34000 - 18040000 [ 0.000000] ACPI Error: A valid RSDP was not found (20110623/tbxfroot-219) [ 0.000000] 512MB LOWMEM available. [ 0.000000] mapped low ram: 0 - 20000000 [ 0.000000] low ram: 0 - 20000000 [ 0.000000] Zone PFN ranges: [ 0.000000] DMA 0x00000010 -> 0x00001000 [ 0.000000] Normal 0x00001000 -> 0x00020000 [ 0.000000] Movable zone start PFN for each node [ 0.000000] early_node_map[2] active PFN ranges [ 0.000000] 0: 0x00000010 -> 0x0000009f [ 0.000000] 0: 0x00000100 -> 0x00020000 [ 0.000000] On node 0 totalpages: 130959 [ 0.000000] free_area_init_node: node 0, pgdat c083c200, node_mem_map dfc00200 [ 0.000000] DMA zone: 32 pages used for memmap [ 0.000000] DMA zone: 0 pages reserved [ 0.000000] DMA zone: 3951 pages, LIFO batch:0 [ 0.000000] Normal zone: 992 pages used for memmap [ 0.000000] Normal zone: 125984 pages, LIFO batch:31 [ 0.000000] Using APIC driver default [ 0.000000] No local APIC present or hardware disabled [ 0.000000] APIC: disable apic facility [ 0.000000] APIC: switched to apic NOOP [ 0.000000] nr_irqs_gsi: 16 [ 0.000000] PM: Registered nosave memory: 000000000009f000 - 00000000000a0000 [ 0.000000] PM: Registered nosave memory: 00000000000a0000 - 00000000000e4000 [ 0.000000] PM: Registered nosave memory: 00000000000e4000 - 0000000000100000 [ 0.000000] Allocating PCI resources starting at 20000000 (gap: 20000000:df000000) [ 0.000000] pcpu-alloc: s0 r0 d32768 u32768 alloc=1*32768 [ 0.000000] pcpu-alloc: [0] 0 [ 0.000000] Built 1 zonelists in Zone order, mobility grouping on. Total pages: 129935 [ 0.000000] Kernel command line: BOOT_IMAGE=/boot/vmlinuz-3.1.0-vortex root=UUID=0b45b03b-8787-4759-9bd0-ef4a48ca6169 ro quiet [ 0.000000] PID hash table entries: 2048 (order: 1, 8192 bytes) [ 0.000000] Dentry cache hash table entries: 65536 (order: 6, 262144 bytes) [ 0.000000] Inode-cache hash table entries: 32768 (order: 5, 131072 bytes) [ 0.000000] Initializing CPU#0 [ 0.000000] allocated 2096896 bytes of page_cgroup [ 0.000000] please try 'cgroup_disable=memory' option if you don't want memory cgroups [ 0.000000] Memory: 503100k/524288k available (5069k kernel code, 20736k reserved, 2372k data, 568k init, 0k highmem) [ 0.000000] virtual kernel memory layout: [ 0.000000] fixmap : 0xfffa2000 - 0xfffff000 ( 372 kB) [ 0.000000] vmalloc : 0xe0800000 - 0xfffa0000 ( 503 MB) [ 0.000000] lowmem : 0xc0000000 - 0xe0000000 ( 512 MB) [ 0.000000] .init : 0xc0845000 - 0xc08d3000 ( 568 kB) [ 0.000000] .data : 0xc05f3532 - 0xc08447a0 (2372 kB) [ 0.000000] .text : 0xc0100000 - 0xc05f3532 (5069 kB) [ 0.000000] Checking if this processor honours the WP bit even in supervisor mode...Ok. [ 0.000000] SLUB: Genslabs=15, HWalign=32, Order=0-3, MinObjects=0, CPUs=1, Nodes=1 [ 0.000000] NR_IRQS:2304 nr_irqs:256 16 [ 0.000000] CPU 0 irqstacks, hard=df406000 soft=df408000 [ 0.000000] Console: colour VGA+ 80x25 [ 0.000000] console [tty0] enabled [ 0.000000] Fast TSC calibration using PIT [ 0.000000] Detected 1000.090 MHz processor. [ 0.008010] Calibrating delay loop (skipped), value calculated using timer frequency.. 2000.18 BogoMIPS (lpj=4000360) [ 0.008053] pid_max: default: 32768 minimum: 301 [ 0.008273] Security Framework initialized [ 0.008322] SELinux: Disabled at boot. [ 0.008495] Mount-cache hash table entries: 512 [ 0.012834] Initializing cgroup subsys cpuacct [ 0.012874] Initializing cgroup subsys memory [ 0.012972] Initializing cgroup subsys devices [ 0.012993] Initializing cgroup subsys freezer [ 0.013013] Initializing cgroup subsys net_cls [ 0.013228] CPU: Vortex86 SoC 05/02 stepping 02 [ 0.013355] ftrace: allocating 21380 entries in 42 pages [ 0.020366] Performance Events: [ 0.024940] devtmpfs: initialized [ 0.027190] print_constraints: dummy: [ 0.027675] NET: Registered protocol family 16 [ 0.029428] EISA bus registered [ 0.031049] PCI: PCI BIOS revision 3.00 entry at 0xf0031, last bus=0 [ 0.031071] PCI: Using configuration type 1 for base access [ 0.052745] bio: create slab <bio-0> at 0 [ 0.053423] ACPI: Interpreter disabled. [ 0.054372] vgaarb: loaded [ 0.057676] SCSI subsystem initialized [ 0.058239] libata version 3.00 loaded. [ 0.058973] usbcore: registered new interface driver usbfs [ 0.059154] usbcore: registered new interface driver hub [ 0.059487] usbcore: registered new device driver usb [ 0.060905] PCI: Probing PCI hardware [ 0.060928] PCI: Probing PCI hardware (bus 00) [ 0.061252] pci 0000:00:00.0: [17f3:6021] type 0 class 0x000600 [ 0.061411] pci 0000:00:02.0: [168c:0029] type 0 class 0x000280 [ 0.061463] pci 0000:00:02.0: reg 10: [mem 0xfef90000-0xfef9ffff] [ 0.061569] pci 0000:00:02.0: PME# supported from D0 D3hot [ 0.061595] pci 0000:00:02.0: PME# disabled [ 0.061678] pci 0000:00:03.0: [18ca:0020] type 0 class 0x000300 [ 0.061723] pci 0000:00:03.0: reg 10: [mem 0xf8000000-0xfbffffff pref] [ 0.061759] pci 0000:00:03.0: reg 14: [mem 0xfefc0000-0xfeffffff] [ 0.061794] pci 0000:00:03.0: reg 18: [io 0xdf80-0xdfff] [ 0.061875] pci 0000:00:03.0: supports D1 D2 [ 0.061959] pci 0000:00:07.0: [17f3:6031] type 0 class 0x000601 [ 0.062115] pci 0000:00:08.0: [17f3:6040] type 0 class 0x000200 [ 0.062155] pci 0000:00:08.0: reg 10: [io 0xde00-0xdeff] [ 0.062190] pci 0000:00:08.0: reg 14: [mem 0xfefbb400-0xfefbb4ff] [ 0.062259] pci 0000:00:08.0: reg 30: [mem 0xfefa0000-0xfefaffff pref] [ 0.062352] pci 0000:00:0a.0: [17f3:6060] type 0 class 0x000c03 [ 0.062392] pci 0000:00:0a.0: reg 10: [mem 0xfefb9000-0xfefb9fff] [ 0.062533] pci 0000:00:0a.1: [17f3:6061] type 0 class 0x000c03 [ 0.062573] pci 0000:00:0a.1: reg 10: [mem 0xfefbb800-0xfefbb8ff] [ 0.062736] pci 0000:00:0b.0: [17f3:6060] type 0 class 0x000c03 [ 0.062778] pci 0000:00:0b.0: reg 10: [mem 0xfefba000-0xfefbafff] [ 0.062919] pci 0000:00:0b.1: [17f3:6061] type 0 class 0x000c03 [ 0.062960] pci 0000:00:0b.1: reg 10: [mem 0xfefbbc00-0xfefbbcff] [ 0.063113] pci 0000:00:0c.0: [17f3:1011] type 0 class 0x000101 [ 0.063153] pci 0000:00:0c.0: reg 10: [io 0x0000-0x0007] [ 0.063187] pci 0000:00:0c.0: reg 14: [io 0x0000-0x0003] [ 0.063220] pci 0000:00:0c.0: reg 18: [io 0x0000-0x0007] [ 0.063254] pci 0000:00:0c.0: reg 1c: [io 0x0000-0x0003] [ 0.063287] pci 0000:00:0c.0: reg 20: [io 0xef00-0xef0f] [ 0.064234] vgaarb: device added: PCI:0000:00:03.0,decodes=io+mem,owns=io+mem,locks=none [ 0.066351] pci 0000:00:07.0: default IRQ router [17f3:6031] [ 0.066483] PCI: pci_cache_line_size set to 32 bytes [ 0.066670] reserve RAM buffer: 000000000009fc00 - 000000000009ffff [ 0.067622] NetLabel: Initializing [ 0.067642] NetLabel: domain hash size = 128 [ 0.067657] NetLabel: protocols = UNLABELED CIPSOv4 [ 0.067779] NetLabel: unlabeled traffic allowed by default [ 0.068287] Switching to clocksource pit [ 0.097013] pnp: PnP ACPI: disabled [ 0.097040] PnPBIOS: Scanning system for PnP BIOS support... [ 0.097133] PnPBIOS: Found PnP BIOS installation structure at 0xc00f3ba0 [ 0.097161] PnPBIOS: PnP BIOS version 1.0, entry 0xf0000:0x456a, dseg 0xf0000 [ 0.097467] pnp 00:00: [mem 0x00000000-0x0009fbff] [ 0.097494] pnp 00:00: [mem 0x0009fc00-0x0009ffff] [ 0.097518] pnp 00:00: [mem 0x000e4000-0x000fffff] [ 0.097542] pnp 00:00: [mem 0x00100000-0x1fffffff] [ 0.097566] pnp 00:00: [mem 0xff000000-0xffffffff] [ 0.097903] system 00:00: [mem 0x00000000-0x0009fbff] could not be reserved [ 0.097936] system 00:00: [mem 0x0009fc00-0x0009ffff] could not be reserved [ 0.097967] system 00:00: [mem 0x000e4000-0x000fffff] could not be reserved [ 0.097997] system 00:00: [mem 0x00100000-0x1fffffff] could not be reserved [ 0.098028] system 00:00: [mem 0xff000000-0xffffffff] has been reserved [ 0.098062] system 00:00: Plug and Play BIOS device, IDs PNP0c01 (active) [ 0.098138] pnp 00:01: [io 0x0020-0x0021] [ 0.098161] pnp 00:01: [io 0x00a0-0x00a1] [ 0.098185] pnp 00:01: [irq 2] [ 0.098371] pnp 00:01: Plug and Play BIOS device, IDs PNP0000 (active) [ 0.098448] pnp 00:02: [dma 4] [ 0.098470] pnp 00:02: [io 0x0000-0x000f] [ 0.098493] pnp 00:02: [io 0x0080-0x0090] [ 0.098515] pnp 00:02: [io 0x0094-0x009f] [ 0.098537] pnp 00:02: [io 0x00c0-0x00de] [ 0.098724] pnp 00:02: Plug and Play BIOS device, IDs PNP0200 (active) [ 0.098801] pnp 00:03: [irq 0] [ 0.098823] pnp 00:03: [io 0x0040-0x0043] [ 0.099008] pnp 00:03: Plug and Play BIOS device, IDs PNP0100 (active) [ 0.099087] pnp 00:04: [irq 8] [ 0.099109] pnp 00:04: [io 0x0070-0x0071] [ 0.099296] pnp 00:04: Plug and Play BIOS device, IDs PNP0b00 (active) [ 0.099376] pnp 00:05: [irq 1] [ 0.099398] pnp 00:05: [io 0x0060] [ 0.099418] pnp 00:05: [io 0x0064] [ 0.099619] pnp 00:05: Plug and Play BIOS device, IDs PNP0303 (active) [ 0.099673] PNPBIOS fault.. attempting recovery. [ 0.099824] PnPBIOS: Warning! Your PnP BIOS caused a fatal error. Attempting to continue [ 0.099938] PnPBIOS: You may need to reboot with the "pnpbios=off" option to operate stably [ 0.100051] PnPBIOS: Check with your vendor for an updated BIOS [ 0.100146] PnPBIOS: get_dev_node: unexpected status 0x3a [ 0.100238] PnPBIOS: 6 nodes reported by PnP BIOS; 6 recorded by driver [ 0.121062] PCI: max bus depth: 0 pci_try_num: 1 [ 0.121115] pci_bus 0000:00: resource 0 [io 0x0000-0xffff] [ 0.121141] pci_bus 0000:00: resource 1 [mem 0x00000000-0xffffffff] [ 0.121512] NET: Registered protocol family 2 [ 0.121970] IP route cache hash table entries: 4096 (order: 2, 16384 bytes) [ 0.123583] TCP established hash table entries: 16384 (order: 5, 131072 bytes) [ 0.124150] TCP bind hash table entries: 16384 (order: 4, 65536 bytes) [ 0.124426] TCP: Hash tables configured (established 16384 bind 16384) [ 0.124446] TCP reno registered [ 0.124469] UDP hash table entries: 256 (order: 0, 4096 bytes) [ 0.124512] UDP-Lite hash table entries: 256 (order: 0, 4096 bytes) [ 0.125033] NET: Registered protocol family 1 [ 0.125142] pci 0000:00:03.0: Boot video device [ 0.143774] PCI: CLS mismatch (64 != 16), using 32 bytes [ 0.164196] Trying to unpack rootfs image as initramfs... [ 1.142734] Freeing initrd memory: 5168k freed [ 1.165927] audit: initializing netlink socket (disabled) [ 1.166023] type=2000 audit(1320360344.160:1): initialized [ 1.262309] HugeTLB registered 4 MB page size, pre-allocated 0 pages [ 1.287011] VFS: Disk quotas dquot_6.5.2 [ 1.287522] Dquot-cache hash table entries: 1024 (order 0, 4096 bytes) [ 1.293969] fuse init (API version 7.17) [ 1.295051] msgmni has been set to 992 [ 1.297252] Block layer SCSI generic (bsg) driver version 0.4 loaded (major 253) [ 1.297281] io scheduler noop registered [ 1.297299] io scheduler deadline registered [ 1.297357] io scheduler cfq registered (default) [ 1.299641] isapnp: Scanning for PnP cards... [ 1.653963] isapnp: No Plug & Play device found [ 1.654392] Serial: 8250/16550 driver, 4 ports, IRQ sharing enabled [ 1.659068] serial8250: ttyS0 at I/O 0x3f8 (irq = 4) is a 16550A [ 1.663735] serial8250: ttyS1 at I/O 0x2f8 (irq = 3) is a 16550A [ 1.679204] brd: module loaded [ 1.686379] loop: module loaded [ 1.702633] Fixed MDIO Bus: probed [ 1.703179] tun: Universal TUN/TAP device driver, 1.6 [ 1.703200] tun: (C) 1999-2004 Max Krasnyansky <maxk@qualcomm.com> [ 1.703547] PPP generic driver version 2.4.2 [ 1.704652] ehci_hcd: USB 2.0 'Enhanced' Host Controller (EHCI) Driver [ 1.704832] ehci_hcd 0000:00:0a.1: EHCI Host Controller [ 1.705230] ehci_hcd 0000:00:0a.1: new USB bus registered, assigned bus number 1 [ 1.727888] ehci_hcd 0000:00:0a.1: irq 9, io mem 0xfefbb800 [ 1.739850] ehci_hcd 0000:00:0a.1: USB 2.0 started, EHCI 1.00 [ 1.741043] hub 1-0:1.0: USB hub found [ 1.741096] hub 1-0:1.0: 2 ports detected [ 1.741546] ehci_hcd 0000:00:0b.1: EHCI Host Controller [ 1.741980] ehci_hcd 0000:00:0b.1: new USB bus registered, assigned bus number 2 [ 1.763878] ehci_hcd 0000:00:0b.1: irq 11, io mem 0xfefbbc00 [ 1.775849] ehci_hcd 0000:00:0b.1: USB 2.0 started, EHCI 1.00 [ 1.776908] hub 2-0:1.0: USB hub found [ 1.776955] hub 2-0:1.0: 2 ports detected [ 1.777472] ohci_hcd: USB 1.1 'Open' Host Controller (OHCI) Driver [ 1.777619] ohci_hcd 0000:00:0a.0: OHCI Host Controller [ 1.778046] ohci_hcd 0000:00:0a.0: new USB bus registered, assigned bus number 3 [ 1.778160] ohci_hcd 0000:00:0a.0: irq 7, io mem 0xfefb9000 [ 1.862801] hub 3-0:1.0: USB hub found [ 1.862850] hub 3-0:1.0: 2 ports detected [ 1.863259] ohci_hcd 0000:00:0b.0: OHCI Host Controller [ 1.863689] ohci_hcd 0000:00:0b.0: new USB bus registered, assigned bus number 4 [ 1.863892] ohci_hcd 0000:00:0b.0: irq 10, io mem 0xfefba000 [ 1.950905] hub 4-0:1.0: USB hub found [ 1.951010] hub 4-0:1.0: 2 ports detected [ 1.951478] uhci_hcd: USB Universal Host Controller Interface driver [ 1.952204] i8042: PNP: PS/2 Controller [PNP0303] at 0x60,0x64 irq 1 [ 1.952228] i8042: PNP: PS/2 appears to have AUX port disabled, if this is incorrect please boot with i8042.nopnp [ 1.952934] serio: i8042 KBD port at 0x60,0x64 irq 1 [ 1.953913] mousedev: PS/2 mouse device common for all mice [ 1.954784] rtc_cmos 00:04: rtc core: registered rtc_cmos as rtc0 [ 1.954862] rtc0: alarms up to one day, 114 bytes nvram [ 1.955908] device-mapper: uevent: version 1.0.3 [ 1.956642] device-mapper: ioctl: 4.22.0-ioctl (2011-10-19) initialised: dm-devel@redhat.com [ 1.957151] device-mapper: multipath: version 1.3.0 loaded [ 1.957178] device-mapper: multipath round-robin: version 1.0.0 loaded [ 1.958018] EISA: Probing bus 0 at eisa.0 [ 1.958182] EISA: Detected 0 cards. [ 1.958225] cpuidle: using governor ladder [ 1.958244] cpuidle: using governor menu [ 1.960733] TCP cubic registered [ 1.962559] NET: Registered protocol family 10 [ 1.967188] NET: Registered protocol family 17 [ 1.967387] Registering the dns_resolver key type [ 1.967512] Using IPI Shortcut mode [ 1.968556] registered taskstats version 1 [ 1.969274] rtc_cmos 00:04: setting system clock to 2011-11-03 22:45:46 UTC (1320360346) [ 1.969305] BIOS EDD facility v0.16 2004-Jun-25, 0 devices found [ 1.969324] EDD information not available. [ 1.970043] Freeing unused kernel memory: 568k freed [ 1.973325] Write protecting the kernel text: 5072k [ 1.973658] Write protecting the kernel read-only data: 2008k [ 2.113320] udev: starting version 151 [ 2.114626] udevd (52): /proc/52/oom_adj is deprecated, please use /proc/52/oom_score_adj instead. [ 2.171952] Switching to clocksource tsc [ 2.307975] usb 3-2: new full-speed USB device number 2 using ohci_hcd [ 2.727322] pata_rdc 0000:00:0c.0: version 0.01 [ 2.727379] pata_rdc: Detected Vortex86DX Bug. [ 2.727394] pata_rdc: Disabling UDMA. [ 2.727646] pata_rdc 0000:00:0c.0: setting latency timer to 64 [ 2.763662] scsi0 : pata_rdc [ 2.768570] scsi1 : pata_rdc [ 2.769069] ata1: PATA max MWDMA2 cmd 0x1f0 ctl 0x3f6 bmdma 0xef00 irq 14 [ 2.769099] ata2: PATA max MWDMA2 cmd 0x170 ctl 0x376 bmdma 0xef08 irq 15 [ 2.835952] usb 4-1: new full-speed USB device number 2 using ohci_hcd [ 2.940330] ata2.00: CFA: TRANSCEND, 20080820, max UDMA/66 [ 2.940371] ata2.00: 7831152 sectors, multi 0: LBA [ 2.956125] ata2.00: configured for MWDMA2 [ 2.956892] scsi 1:0:0:0: Direct-Access ATA TRANSCEND 2008 PQ: 0 ANSI: 5 [ 2.958033] sd 1:0:0:0: [sda] 7831152 512-byte logical blocks: (4.00 GB/3.73 GiB) [ 2.958695] sd 1:0:0:0: [sda] Write Protect is off [ 2.958727] sd 1:0:0:0: [sda] Mode Sense: 00 3a 00 00 [ 2.959010] sd 1:0:0:0: [sda] Write cache: disabled, read cache: enabled, doesn't support DPO or FUA [ 2.960781] sd 1:0:0:0: Attached scsi generic sg0 type 0 [ 2.965400] input: C-Media USB Audio Device as /devices/pci0000:00/0000:00:0a.0/usb3/3-2/3-2:1.3/input/input0 [ 2.966734] generic-usb 0003:0D8C:0008.0001: input,hidraw0: USB HID v1.00 Device [C-Media USB Audio Device ] on usb-0000:00:0a.0-2/input3 [ 2.967685] usbcore: registered new interface driver usbhid [ 2.967711] usbhid: USB HID core driver [ 3.001011] hub 4-1:1.0: USB hub found [ 3.002823] hub 4-1:1.0: 3 ports detected [ 3.297800] usb 4-1.1: new full-speed USB device number 3 using ohci_hcd [ 3.428303] input: Lite-On Technology USB Productivity Option Keyboard( has the hub in # 1 ) as /devices/pci0000:00/0000:00:0b.0/usb4/4-1/4-1.1/4-1.1:1.0/input/input1 [ 3.429731] generic-usb 0003:04B3:301B.0002: input,hidraw1: USB HID v1.10 Keyboard [Lite-On Technology USB Productivity Option Keyboard( has the hub in # 1 )] on usb-0000:00:0b.0-1.1/input0 [ 3.443707] input: Lite-On Technology USB Productivity Option Keyboard( has the hub in # 1 ) as /devices/pci0000:00/0000:00:0b.0/usb4/4-1/4-1.1/4-1.1:1.1/input/input2 [ 3.445122] generic-usb 0003:04B3:301B.0003: input,hidraw2: USB HID v1.10 Device [Lite-On Technology USB Productivity Option Keyboard( has the hub in # 1 )] on usb-0000:00:0b.0-1.1/input1 [ 3.525794] usb 4-1.3: new low-speed USB device number 4 using ohci_hcd [ 3.647494] input: USB Optical Mouse as /devices/pci0000:00/0000:00:0b.0/usb4/4-1/4-1.3/4-1.3:1.0/input/input3 [ 3.650467] generic-usb 0003:04B3:310C.0004: input,hidraw3: USB HID v1.11 Mouse [USB Optical Mouse] on usb-0000:00:0b.0-1.3/input0 [ 33.822836] ata2: lost interrupt (Status 0x58) [ 33.824367] ata2: drained 2048 bytes to clear DRQ [ 33.824417] ata2.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x6 frozen [ 33.824541] ata2.00: failed command: READ DMA [ 33.824665] ata2.00: cmd c8/00:08:00:00:00/00:00:00:00:00/e0 tag 0 dma 4096 in [ 33.824679] res 40/00:00:00:00:00/00:00:00:00:00/00 Emask 0x4 (timeout) [ 33.824925] ata2.00: status: { DRDY } [ 33.825074] ata2: soft resetting link [ 33.987099] ata2.00: failed to IDENTIFY (INIT_DEV_PARAMS failed, err_mask=0x80) [ 33.987128] ata2.00: revalidation failed (errno=-5) [ 38.978651] ata2: soft resetting link [ 39.142916] ata2.00: failed to IDENTIFY (INIT_DEV_PARAMS failed, err_mask=0x80) [ 39.142945] ata2.00: revalidation failed (errno=-5) [ 44.134479] ata2: soft resetting link [ 44.298746] ata2.00: failed to IDENTIFY (INIT_DEV_PARAMS failed, err_mask=0x80) [ 44.298774] ata2.00: revalidation failed (errno=-5) [ 44.298877] ata2.00: disabled [ 44.298920] ata2.00: device reported invalid CHS sector 0 [ 44.299018] ata2: EH complete [ 44.299114] sd 1:0:0:0: [sda] Unhandled error code [ 44.299138] sd 1:0:0:0: [sda] Result: hostbyte=DID_BAD_TARGET driverbyte=DRIVER_OK [ 44.299170] sd 1:0:0:0: [sda] CDB: Read(10): 28 00 00 00 00 00 00 00 08 00 [ 44.299243] end_request: I/O error, dev sda, sector 0 [ 44.299351] Buffer I/O error on device sda, logical block 0 [ 44.299708] sd 1:0:0:0: [sda] Unhandled error code [ 44.299733] sd 1:0:0:0: [sda] Result: hostbyte=DID_BAD_TARGET driverbyte=DRIVER_OK [ 44.299763] sd 1:0:0:0: [sda] CDB: Read(10): 28 00 00 00 00 00 00 00 08 00 [ 44.299832] end_request: I/O error, dev sda, sector 0 [ 44.299936] Buffer I/O error on device sda, logical block 0 [ 44.300313] sd 1:0:0:0: [sda] Unhandled error code [ 44.300338] sd 1:0:0:0: [sda] Result: hostbyte=DID_BAD_TARGET driverbyte=DRIVER_OK [ 44.300368] sd 1:0:0:0: [sda] CDB: Read(10): 28 00 00 00 00 00 00 00 08 00 [ 44.300438] end_request: I/O error, dev sda, sector 0 [ 44.300542] Buffer I/O error on device sda, logical block 0 [ 44.300703] ldm_validate_partition_table(): Disk read failed. [ 44.300932] sd 1:0:0:0: [sda] Unhandled error code [ 44.300956] sd 1:0:0:0: [sda] Result: hostbyte=DID_BAD_TARGET driverbyte=DRIVER_OK [ 44.300986] sd 1:0:0:0: [sda] CDB: Read(10): 28 00 00 00 00 00 00 00 08 00 [ 44.301056] end_request: I/O error, dev sda, sector 0 [ 44.301160] Buffer I/O error on device sda, logical block 0 [ 44.301318] sda: unable to read partition table [ 44.303020] sd 1:0:0:0: [sda] READ CAPACITY(16) failed [ 44.303047] sd 1:0:0:0: [sda] Result: hostbyte=DID_BAD_TARGET driverbyte=DRIVER_OK [ 44.303079] sd 1:0:0:0: [sda] Sense not available. [ 44.303423] sd 1:0:0:0: [sda] READ CAPACITY failed [ 44.303447] sd 1:0:0:0: [sda] Result: hostbyte=DID_BAD_TARGET driverbyte=DRIVER_OK [ 44.303477] sd 1:0:0:0: [sda] Sense not available. [ 44.303943] sd 1:0:0:0: [sda] Truncating mode parameter data from 8309 to 512 bytes [ 44.304095] sd 1:0:0:0: [sda] Got wrong page [ 44.304198] sd 1:0:0:0: [sda] Assuming drive cache: write through [ 44.304310] sd 1:0:0:0: [sda] Attached SCSI disk On Mon, Oct 31, 2011 at 8:02 PM, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote: > On Mon, 31 Oct 2011 14:07:45 -0500 > Paul Schilling <paul.s.schilling@gmail.com> wrote: > >> Hi, >> >> When I developed this patch for the Vortex86dx. I recall trying many >> combinations of udma and mwdma. At the time I developed it, I came >> to the conclusion that both udma and mwdma both failed with CRC >> errors being reported. > > MWDMA does not have a CRC so that seems unlikely. If you can re-test and > we can figure out what is going on that would be useful. > > Alan > ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 02/15] ATA : vortex86 : fix vortex86dx/sx hardware CRC bug. 2011-11-03 22:58 ` Paul Schilling @ 2011-11-03 23:19 ` Alan Cox 0 siblings, 0 replies; 12+ messages in thread From: Alan Cox @ 2011-11-03 23:19 UTC (permalink / raw) To: Paul Schilling Cc: Jeff Garzik, David S. Miller, Jesse Barnes, linux-ide, linux-kernel, linux-pci > [ 33.822836] ata2: lost interrupt (Status 0x58) > [ 33.824367] ata2: drained 2048 bytes to clear DRQ So you have a different problem - your IRQ delivery appears to be broken. ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2011-11-03 23:18 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <fix vortex86>
2011-10-23 5:05 ` [PATCH 02/15] ATA : vortex86 : fix vortex86dx/sx hardware CRC bug Paul Schilling
2011-10-23 8:20 ` Rolf Eike Beer
2011-10-23 16:26 ` Paul Schilling
2011-10-26 4:16 ` Paul Schilling
2011-10-27 7:43 ` Alan Cox
2011-10-27 18:55 ` Paul Schilling
2011-10-27 19:03 ` Paul Schilling
2011-10-28 18:27 ` Alan Cox
2011-10-31 19:07 ` Paul Schilling
2011-11-01 1:02 ` Alan Cox
2011-11-03 22:58 ` Paul Schilling
2011-11-03 23:19 ` Alan Cox
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).