From: Alessandro Rubini <rubini@gnudd.com>
To: alan@linux.intel.com
Cc: linux-kernel@vger.kernel.org, giancarlo.asnaghi@st.com,
tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
x86@kernel.org, jgarzik@pobox.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH 6/6] ahci: support the STA2X11 I/O Hub
Date: Thu, 12 Jan 2012 00:26:36 +0100 [thread overview]
Message-ID: <20120111232636.GA19503@mail.gnudd.com> (raw)
In-Reply-To: <20120111225748.3e80a52d@bob.linux.org.uk>
[I miscopied linux-ide to inux-ide in the original submission. I'm
now fixing the typo. This is the original patch and I quote Alan
without removing anything: https://lkml.org/lkml/2012/1/6/124 ]
>> The AHCI controller found in the STA2X11 chip uses BAR number 0
>> instead of 5. Also, the chip's fixup code sets a special DMA mask
>> for all of its PCI functions, and the mask must be preserved here.
>
> The more I look at this aspect of it the more convinced I grow that you
> should handle this in the DMA ops.
>
> dma_supported will call ops->dma_supported which can in turn make its
> own decisions and avoid driver hackery.
The problem is that there's dma_capable() somewhere. Currently I have
very bad feeling about dma_capable and I'll try to turn that to
dma_supported as soon as possible (the code I got changed the
behaviour of dma_capable, which is a global change impacting on
others).
thanks
/alessandro
parent reply other threads:[~2012-01-11 23:27 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <78cef636f264afa64de043be2018b5d66290240e.1325852059.git.rubini@gnudd.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120111232636.GA19503@mail.gnudd.com \
--to=rubini@gnudd.com \
--cc=alan@linux.intel.com \
--cc=giancarlo.asnaghi@st.com \
--cc=hpa@zytor.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).