* Re: [PATCH 6/6] ahci: support the STA2X11 I/O Hub
[not found] ` <78cef636f264afa64de043be2018b5d66290240e.1325852059.git.rubini@gnudd.com>
@ 2012-01-11 23:26 ` Alessandro Rubini
0 siblings, 0 replies; only message in thread
From: Alessandro Rubini @ 2012-01-11 23:26 UTC (permalink / raw)
To: alan
Cc: linux-kernel, giancarlo.asnaghi, tglx, mingo, hpa, x86, jgarzik,
linux-ide
[I miscopied linux-ide to inux-ide in the original submission. I'm
now fixing the typo. This is the original patch and I quote Alan
without removing anything: https://lkml.org/lkml/2012/1/6/124 ]
>> The AHCI controller found in the STA2X11 chip uses BAR number 0
>> instead of 5. Also, the chip's fixup code sets a special DMA mask
>> for all of its PCI functions, and the mask must be preserved here.
>
> The more I look at this aspect of it the more convinced I grow that you
> should handle this in the DMA ops.
>
> dma_supported will call ops->dma_supported which can in turn make its
> own decisions and avoid driver hackery.
The problem is that there's dma_capable() somewhere. Currently I have
very bad feeling about dma_capable and I'll try to turn that to
dma_supported as soon as possible (the code I got changed the
behaviour of dma_capable, which is a global change impacting on
others).
thanks
/alessandro
^ permalink raw reply [flat|nested] only message in thread