From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Jeff Garzik <jeff@garzik.org>, Lin Ming <ming.m.lin@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-ide@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [git patches] libata updates for 3.3
Date: Tue, 17 Jan 2012 00:18:12 +0000 [thread overview]
Message-ID: <20120117001812.GA9588@srcf.ucam.org> (raw)
In-Reply-To: <CA+55aFyafh6cCiV=mMA6Z7qtWqBrJ_pGPev09PP14nJ8Hc=vmg@mail.gmail.com>
On Mon, Jan 16, 2012 at 04:02:31PM -0800, Linus Torvalds wrote:
> On Mon, Jan 16, 2012 at 3:54 PM, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> >> Part of the problem with force-enable is that the MMIO BAR may need a
> >> value, and not have it. That, and an expectations mismatch between BIOS
> >
> > That's fine - we can happily assign one at boot time.
>
> Actually, I think the reason that Matthews patch doesn't work for me
> is that on my device, BAR #5 really is a _port_ BAR.
>
> I didn't play with it much - busy merging and looking at various other
> issues - but I'm starting to wonder whether maybe that 8086:1c01 chip
> doesn't support AHCI at all. Or maybe it does something differently.
>
> Other reports of this have BAR#5 either clear, or an MMIO BAR. That
>
> Region 5: I/O ports at ffe0 [size=16]
>
> looks really odd. Matthew's patch uses
>
> pci_assign_resource(pdev, 5);
>
> but if it is a PIO region, that won't help anything..
More recent ICHs may need different setup here. The datasheet should
have enough to figure it out, but I can take a look once I get back from
LCA.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2012-01-17 0:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 0:32 [git patches] libata updates for 3.3 Jeff Garzik
2012-01-14 5:21 ` Linus Torvalds
2012-01-15 14:41 ` Jeff Garzik
2012-01-16 1:15 ` Lin Ming
2012-01-16 5:23 ` Lin Ming
2012-01-16 19:25 ` Linus Torvalds
2012-01-16 19:29 ` Linus Torvalds
2012-01-16 19:55 ` Linus Torvalds
2012-01-17 5:16 ` Lin Ming
2012-01-17 5:19 ` Linus Torvalds
2012-01-17 16:51 ` Jeff Garzik
2012-01-17 17:00 ` Jeff Garzik
2012-01-16 19:42 ` Alan Cox
2012-01-16 19:47 ` Linus Torvalds
2012-01-16 19:54 ` Alan Cox
2012-01-16 20:02 ` Linus Torvalds
2012-01-16 20:21 ` Linus Torvalds
2012-01-16 20:27 ` Jeff Garzik
2012-01-16 23:54 ` Alan Cox
2012-01-17 0:02 ` Linus Torvalds
2012-01-17 0:18 ` Matthew Garrett [this message]
2012-01-16 21:26 ` Matthew Garrett
2012-01-16 21:34 ` Linus Torvalds
2012-01-16 22:03 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120117001812.GA9588@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).