From: Tejun Heo <tj@kernel.org>
To: Brian Norris <computersforpeace@gmail.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
linux-ide@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: Deferred disk spinup during system resume
Date: Mon, 20 Aug 2012 13:57:46 -0700 [thread overview]
Message-ID: <20120820205746.GV24861@google.com> (raw)
In-Reply-To: <CAN8TOE_Y2EgSoK4euCC6fp1jr8bKyjdoVJq=Kk8fnG6qZboTGQ@mail.gmail.com>
Hello, Brian.
On Fri, Aug 17, 2012 at 07:12:30PM -0700, Brian Norris wrote:
> I understand that your original patch was given the "not tested"
> disclaimer, but I wanted to know if you had any immediate advice on
> why this failed so miserably for me, before I go trying to dig in to
> this issue more deeply. For instance, maybe there's been enough code
> change between 2.6.37 and 3.3 (or current upstream - 3.6-rc2) that
> would require a change in approach.
Yeah, I'm not particularly fond of how resume is implemented. It can
and should be more asynchronous, I think. :( Unfortunately, I'm a bit
too preoccupied at the moment. A quick & dirty hack would be simply
skipping ATA_CMD_VERIFY so that the drive spins up on the actual next
command. If that's acceptable, just add "goto skip;" right after "if
(cdb[4] & 0x1)" test in ata_scsi_start_stop_xlat().
Thanks.
--
tejun
next prev parent reply other threads:[~2012-08-20 20:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-18 2:12 Deferred disk spinup during system resume Brian Norris
2012-08-20 20:57 ` Tejun Heo [this message]
2012-09-15 3:36 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120820205746.GV24861@google.com \
--to=tj@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).