From: Tejun Heo <tj@kernel.org>
To: Brian Norris <computersforpeace@gmail.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
linux-ide@vger.kernel.org, linux-pm@lists.linux-foundation.org,
Linux Kernel <linux-kernel@vger.kernel.org>,
Kevin Cernekee <cernekee@gmail.com>
Subject: Re: [RFC 3/3] libata: don't perform HW activity in devres
Date: Thu, 25 Oct 2012 10:25:42 -0700 [thread overview]
Message-ID: <20121025172542.GG11442@htj.dyndns.org> (raw)
In-Reply-To: <1351184161-31433-4-git-send-email-computersforpeace@gmail.com>
On Thu, Oct 25, 2012 at 09:56:01AM -0700, Brian Norris wrote:
> devres functions are intended for simplified cleanup of memory and other
> software resources on device exit, not for hardware shutdown sequences.
> In addition, inducing hardware activity at device removal hamstrings
> some drivers (particularly ahci_platform) so that they cannot totally
> power off their hardware before removal, as devres cleanup occurs after
> the driver's exit() sequence.
>
> More concretely, I experience the following bus error when using rmmod
> to remove (and power off) the SATA block on my SoC:
Shouldn't poweroff happen from ->port/host_stop()?
Thanks.
--
tejun
next prev parent reply other threads:[~2012-10-25 17:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-25 16:55 [RFC 0/3] libata/ahci unbinding, power down sequence Brian Norris
2012-10-25 16:55 ` [RFC 1/3] ahci_platform: enable hotplug unbinding Brian Norris
2012-10-25 16:56 ` [RFC 2/3] ahci_platform: convert to module_platform_driver Brian Norris
2012-10-25 16:56 ` [RFC 3/3] libata: don't perform HW activity in devres Brian Norris
2012-10-25 17:25 ` Tejun Heo [this message]
2012-10-25 17:41 ` Brian Norris
2012-10-25 17:43 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121025172542.GG11442@htj.dyndns.org \
--to=tj@kernel.org \
--cc=cernekee@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).