From: Tejun Heo <tj@kernel.org>
To: Brian Norris <computersforpeace@gmail.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
linux-ide@vger.kernel.org, linux-pm@lists.linux-foundation.org,
Kevin Cernekee <cernekee@gmail.com>
Subject: Re: [RFC v2 3/3] ahci_platform: perform platform exit in host_stop() hook
Date: Thu, 1 Nov 2012 09:17:14 -0700 [thread overview]
Message-ID: <20121101161714.GC9169@htj.dyndns.org> (raw)
In-Reply-To: <CAN8TOE_RZtpnEnNuM2ZyODGGURUWDba57vVOHa0BEsh5h8wFPQ@mail.gmail.com>
Hello, Brian.
On Wed, Oct 31, 2012 at 11:41:45PM -0700, Brian Norris wrote:
> > If you have some time, it would be nice to introduce
> > ata_platform_remove_one(). There's no reason to have that implemented
> > separately in each driver.
>
> OK, I think I have a pretty good set of patches. I have about 8
> drivers switched over to a new ata_platform_remove_one(). Should I
> submit it with my resend of this series?
I think both ways should be fine.
> > It would also be nice to move
> > remove_one()'s to some higher level port_ops so that individual
> > drivers don't have to specify them explicitly.
>
> Hmm, which port op would you recommend? host_stop()? Or a new remove_one() op?
Heh, that was me being confused. Please disregard. I for some reason
thought .remove is an ata operation. :)
Thanks.
--
tejun
next prev parent reply other threads:[~2012-11-01 16:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-27 20:09 [RFC v2 0/3] ahci_platform: unbind/rmmod power down sequence Brian Norris
2012-10-27 20:09 ` [RFC v2 1/3] ahci_platform: enable hotplug unbinding Brian Norris
2012-10-27 20:09 ` [RFC v2 2/3] ahci_platform: convert to module_platform_driver Brian Norris
2012-10-27 20:09 ` [RFC v2 3/3] ahci_platform: perform platform exit in host_stop() hook Brian Norris
2012-10-29 1:37 ` Tejun Heo
2012-11-01 6:41 ` Brian Norris
2012-11-01 16:17 ` Tejun Heo [this message]
2012-10-28 0:11 ` [linux-pm] [RFC v2 0/3] ahci_platform: unbind/rmmod power down sequence Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121101161714.GC9169@htj.dyndns.org \
--to=tj@kernel.org \
--cc=cernekee@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).