From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Borislav Petkov <bp@alien8.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Jeff Garzik <jgarzik@pobox.com>,
linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: Shut up annoying native_sectors warning
Date: Thu, 20 Dec 2012 13:01:59 +0000 [thread overview]
Message-ID: <20121220130159.7125e700@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <1356006355-6819-1-git-send-email-bp@alien8.de>
On Thu, 20 Dec 2012 13:25:55 +0100
Borislav Petkov <bp@alien8.de> wrote:
> I'm getting this
>
> drivers/ata/libata-core.c: In function ‘ata_hpa_resize’:
> drivers/ata/libata-core.c:1397:3: warning: ‘native_sectors’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>
> for a couple of kernel releases now with gcc (Debian 4.7.2-4) 4.7.2.
>
> And the warning is bogus because ata_read_native_max_address either
> returns a sensible max_sectors aka native_sectors through its second
> arg pointer or an error value which is properly handled in its caller
> ata_hpa_resize().
>
> So shut up gcc already.
And ensure it won't be noticed if a real problem is found. So we go from
warning for a few people who ignore it, to silence for everyone if a real
bug appears
Net lose IMHO - better to file a gcc bug report
Alan
next prev parent reply other threads:[~2012-12-20 12:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-20 12:25 [PATCH] libata: Shut up annoying native_sectors warning Borislav Petkov
2012-12-20 13:01 ` Alan Cox [this message]
2012-12-20 15:04 ` Borislav Petkov
2012-12-20 15:37 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121220130159.7125e700@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=bp@alien8.de \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox