Re: [PATCH] make ata_exec_internal_sg honor DMADIR

[Tejun Heo <tj@kernel.org>]

Hello,

On Mon, May 20, 2013 at 10:43:14PM +0200, Vincent Pelletier wrote:
> Something like this ? (2/2 - untested)
> Is "horkage" just another way to say "quirks" in this context ? Google 
> translate doesn't help, and urbandictionary has too many entries for "hork" to 
> make me confident.

I think so.  It was originally named by Alan Cox who sometimes plays
with old English dialects, Yiddish, whatnot.

> Alternatively, I would add a "dflags" field to struct ata_force_param, and 
> reuse ATA_DFLAG_DMADIR instead of defining a new enum item.
> 
> As this completely supersedes the atapi_dmadir module argument, is there a way 
> to deprecate it (if at all a good practice) ?

I'd just leave it alone.  It's not like it adds a lot of complexity.

> @@ -6498,6 +6498,8 @@ static int __init ata_parse_force_one(char **cur,
>  		{ "nosrst",	.lflags		= ATA_LFLAG_NO_SRST },
>  		{ "norst",	.lflags		= ATA_LFLAG_NO_HRST | ATA_LFLAG_NO_SRST },
>  		{ "rstonce",	.lflags		= ATA_LFLAG_RST_ONCE },
> +		{ "atapi_dmadir", .horkage_on	= ATA_HORKAGE_ATAPI_DMADIR },
> +		{ "noatapi_dmadir", .horkage_off = ATA_HORKAGE_ATAPI_DMADIR },

I don't think we need noatapi_dmadir as the default is off anyway.

Thanks.

-- 
tejun