From: Tejun Heo <tj@kernel.org>
To: Clemens Ladisch <clemens@ladisch.de>
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Timur Tabi <timur.tabi@calxeda.com>,
Mark Langsdorf <mark.langsdorf@calxeda.com>,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH v2] ata: increase retry count but shorten duration for Calxeda controller
Date: Fri, 31 May 2013 16:40:17 +0900 [thread overview]
Message-ID: <20130531074017.GC16809@mtj.dyndns.org> (raw)
In-Reply-To: <51A848F1.3040301@ladisch.de>
On Fri, May 31, 2013 at 08:53:37AM +0200, Clemens Ladisch wrote:
> Sergei Shtylyov wrote:
> > On 30-05-2013 18:26, Timur Tabi wrote:
> >>> + const unsigned long timing[] = { 5, 100, 500};
> >
> >> You'll save space and time if you also make this array "static",
> >> otherwise the compiler will build the array every time this function is
> >> called.
> >
> > No, *const* specifier is enough to not build this array every time. It will be put into the .const section.
>
> gcc disagrees:
Doesn't really matter this or that way but let's do static const as,
more than anything else, that's what other places are doing.
Thanks.
--
tejun
next prev parent reply other threads:[~2013-05-31 7:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 14:18 [PATCH v2] ata: increase retry count but shorten duration for Calxeda controller Mark Langsdorf
2013-05-30 14:26 ` Timur Tabi
2013-05-30 14:38 ` Sergei Shtylyov
2013-05-30 14:39 ` Timur Tabi
2013-05-31 6:53 ` Clemens Ladisch
2013-05-31 7:40 ` Tejun Heo [this message]
2013-05-31 13:13 ` Sergei Shtylyov
2013-05-31 1:20 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130531074017.GC16809@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=clemens@ladisch.de \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.langsdorf@calxeda.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=timur.tabi@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox