From: Tejun Heo <tj@kernel.org>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: linux-ide@vger.kernel.org, vladimir.barinov@cogentembedded.com
Subject: Re: [PATCH] sata_rcar: fix interrupt handling
Date: Sun, 2 Jun 2013 20:49:12 -0700 [thread overview]
Message-ID: <20130603034912.GD6071@mtj.dyndns.org> (raw)
In-Reply-To: <51AB7A1B.4060905@cogentembedded.com>
Hey,
On Sun, Jun 02, 2013 at 09:00:11PM +0400, Sergei Shtylyov wrote:
> >> CC drivers/ata/sata_rcar.o
> >> drivers/ata/sata_rcar.c: In function ‘sata_rcar_thaw’:
> >> drivers/ata/sata_rcar.c:183:2: warning: large integer
> >>implicitly truncated to unsigned type [-Woverflow]
> >
> > It compiles without warnings for me, IIRC. What version of gcc
> >are you using?
>
> >>Care to fix it?
> >
> > I'll look into it...
>
> I tried 4.2.0, 4.3.3 (that one broke with segmentation fault),
> and 4.7.3 and no warning...
> So, please tell me what version you have for the changelog.
I'm on fedora 19 beta x86-64.
$ gcc --version
gcc (GCC) 4.8.0 20130526 (Red Hat 4.8.0-8)
Copyright (C) 2013 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
# make drivers/ata/sata_rcar.o
...
CC drivers/ata/sata_rcar.o
drivers/ata/sata_rcar.c: In function ‘sata_rcar_thaw’:
drivers/ata/sata_rcar.c:183:2: warning: large integer implicitly truncated to unsigned type [-Woverflow]
iowrite32(~SATA_RCAR_INT_MASK, priv->base + SATAINTSTAT_REG);
^
Thanks.
--
tejun
prev parent reply other threads:[~2013-06-03 3:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 22:38 [PATCH] sata_rcar: fix interrupt handling Sergei Shtylyov
2013-05-31 23:06 ` Sergei Shtylyov
2013-06-02 7:58 ` Tejun Heo
2013-06-02 11:39 ` Sergei Shtylyov
2013-06-02 17:00 ` Sergei Shtylyov
2013-06-03 3:49 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130603034912.GD6071@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=vladimir.barinov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox