Re: drivers/ata/sata_rcar.c:183:2: warning: large integer implicitly truncated to unsigned type

Re: drivers/ata/sata_rcar.c:183:2: warning: large integer implicitly truncated to unsigned type

[Simon Horman]

Hi Sergei, Hi Vladimir,

could you look into a fix for this?

I believe that it is a result of my patch "libata: do not limit R-Car SATA
driver to shmobile", which now allows the R-Car SATA driver to be compiled
for a (much) wider range of hardware.

On Wed, May 29, 2013 at 03:24:47PM +0800, Fengguang Wu wrote:
> 
> Hi Simon,
> 
> First bad commit might be:
> 
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next master
> head:   1ca94a12e6c269b0dfc10424c27ff295b3420e9c
> commit: 5c23341ff66c9280c2e76dc9795cd14497ea780f libata: do not limit R-Car SATA driver to shmobile
> date:   5 days ago
> config: make ARCH=powerpc allmodconfig
> 
> All warnings:
> 
>    drivers/ata/sata_rcar.c: In function 'sata_rcar_thaw':
> >> drivers/ata/sata_rcar.c:183:2: warning: large integer implicitly truncated to unsigned type [-Woverflow]
> 
> vim +183 drivers/ata/sata_rcar.c
> 
> 163cf81d Vladimir Barinov 2013-02-20  167  
> 163cf81d Vladimir Barinov 2013-02-20  168  static void sata_rcar_freeze(struct ata_port *ap)
> 163cf81d Vladimir Barinov 2013-02-20  169  {
> 163cf81d Vladimir Barinov 2013-02-20  170  	struct sata_rcar_priv *priv = ap->host->private_data;
> 163cf81d Vladimir Barinov 2013-02-20  171  
> 163cf81d Vladimir Barinov 2013-02-20  172  	/* mask */
> 163cf81d Vladimir Barinov 2013-02-20  173  	iowrite32(0x7ff, priv->base + SATAINTMASK_REG);
> 163cf81d Vladimir Barinov 2013-02-20  174  
> 163cf81d Vladimir Barinov 2013-02-20  175  	ata_sff_freeze(ap);
> 163cf81d Vladimir Barinov 2013-02-20  176  }
> 163cf81d Vladimir Barinov 2013-02-20  177  
> 163cf81d Vladimir Barinov 2013-02-20  178  static void sata_rcar_thaw(struct ata_port *ap)
> 163cf81d Vladimir Barinov 2013-02-20  179  {
> 163cf81d Vladimir Barinov 2013-02-20  180  	struct sata_rcar_priv *priv = ap->host->private_data;
> 163cf81d Vladimir Barinov 2013-02-20  181  
> 163cf81d Vladimir Barinov 2013-02-20  182  	/* ack */
> 163cf81d Vladimir Barinov 2013-02-20 @183  	iowrite32(~SATA_RCAR_INT_MASK, priv->base + SATAINTSTAT_REG);
> 163cf81d Vladimir Barinov 2013-02-20  184  
> 163cf81d Vladimir Barinov 2013-02-20  185  	ata_sff_thaw(ap);
> 163cf81d Vladimir Barinov 2013-02-20  186  
> 163cf81d Vladimir Barinov 2013-02-20  187  	/* unmask */
> 163cf81d Vladimir Barinov 2013-02-20  188  	iowrite32(0x7ff & ~SATA_RCAR_INT_MASK, priv->base + SATAINTMASK_REG);
> 163cf81d Vladimir Barinov 2013-02-20  189  }
> 163cf81d Vladimir Barinov 2013-02-20  190  
> 163cf81d Vladimir Barinov 2013-02-20  191  static void sata_rcar_ioread16_rep(void __iomem *reg, void *buffer, int count)
> 
> 
> 
> ---
> 0-DAY kernel build testing backend              Open Source Technology Center
> http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation
> 

Re: drivers/ata/sata_rcar.c:183:2: warning: large integer implicitly truncated to unsigned type

[Tejun Heo]

On Tue, Jun 04, 2013 at 10:45:21AM +0900, Simon Horman wrote:
> Hi Sergei, Hi Vladimir,
> 
> could you look into a fix for this?
> 
> I believe that it is a result of my patch "libata: do not limit R-Car SATA
> driver to shmobile", which now allows the R-Car SATA driver to be compiled
> for a (much) wider range of hardware.

Already fixed in libata/for-3.11.  Hmmm.... I'll move it into
for-3.10-fixes and push to Linus in a week or so.

Thanks.

-- 
tejun

Re: drivers/ata/sata_rcar.c:183:2: warning: large integer implicitly truncated to unsigned type

[Sergei Shtylyov]

Hello.

On 04-06-2013 5:45, Simon Horman wrote:

> could you look into a fix for this?

> I believe that it is a result of my patch "libata: do not limit R-Car SATA
> driver to shmobile", which now allows the R-Car SATA driver to be compiled
> for a (much) wider range of hardware.

   It is a result of compiling with gcc 4.8. As Tejun wrote, the warning 
has been already fixed and the fix queued in his tree.

WBR, Sergei

Re: drivers/ata/sata_rcar.c:183:2: warning: large integer implicitly truncated to unsigned type

[Simon Horman]

On Tue, Jun 04, 2013 at 02:05:20PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 04-06-2013 5:45, Simon Horman wrote:
> 
> >could you look into a fix for this?
> 
> >I believe that it is a result of my patch "libata: do not limit R-Car SATA
> >driver to shmobile", which now allows the R-Car SATA driver to be compiled
> >for a (much) wider range of hardware.
> 
>   It is a result of compiling with gcc 4.8. As Tejun wrote, the
> warning has been already fixed and the fix queued in his tree.

Thanks and sorry for the noise.