From: Tejun Heo <tj@kernel.org>
To: "Huang, Shane" <Shane.Huang@amd.com>
Cc: Yu Liu <liuyu.ac@gmail.com>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Subject: Re: AHCI bug: a lockup in ahci_interrupt with fbs enabled pmp
Date: Fri, 7 Jun 2013 15:56:39 -0700 [thread overview]
Message-ID: <20130607225639.GH14781@mtj.dyndns.org> (raw)
In-Reply-To: <43EB3AB3EEFE8D43B525F4D2EAF507E1085BAD21@SCYBEXDAG04.amd.com>
On Fri, Jun 07, 2013 at 04:29:47AM +0000, Huang, Shane wrote:
> > Yeah, it's a bug. ata_link_online() can't be called from interrupt
> > handlers. Shane? Can you please look into it? What's the purpose
> > of ata_link_online() in ahci_error_intr()?
>
> ata_link_online() was used to check that pmp link is active...
> which should be replaced by ata_link_active()?
ata_link_sactive() asks whether there are commands in progress. I
don't think that fits in there. Can't it just bounce to EH for actual
error handling? Why is the link online check necessary?
Thanks.
--
tejun
next prev parent reply other threads:[~2013-06-07 22:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-06 6:33 AHCI bug: a lockup in ahci_interrupt with fbs enabled pmp Yu Liu
2013-06-06 21:47 ` Tejun Heo
2013-06-07 4:29 ` Huang, Shane
2013-06-07 22:56 ` Tejun Heo [this message]
2013-06-08 5:59 ` Huang, Shane
2013-06-08 6:01 ` Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2013-06-06 6:31 AHCI bug?: " Yu Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130607225639.GH14781@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=Shane.Huang@amd.com \
--cc=linux-ide@vger.kernel.org \
--cc=liuyu.ac@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).