* [PATCH] ahci: remove pmp link online check in FBS EH
@ 2013-06-08 8:00 Shane Huang
2013-06-09 9:59 ` Liu Yu
2013-06-09 21:59 ` Tejun Heo
0 siblings, 2 replies; 3+ messages in thread
From: Shane Huang @ 2013-06-08 8:00 UTC (permalink / raw)
To: Tejun Heo; +Cc: Yu Liu, linux-ide, stable, Shane Huang
ata_link_online() check in ahci_error_intr() is unnecessary, it should
be removed otherwise may lead to lockup with FBS enabled PMP.
http://marc.info/?l=linux-ide&m=137050421603272&w=2
Reported-by: Yu Liu <liuyu.ac@gmail.com>
Signed-off-by: Shane Huang <shane.huang@amd.com>
Cc: stable@vger.kernel.org
---
drivers/ata/libahci.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
index a70ff15..7b9bdd8 100644
--- a/drivers/ata/libahci.c
+++ b/drivers/ata/libahci.c
@@ -1560,8 +1560,7 @@ static void ahci_error_intr(struct ata_port *ap, u32 irq_stat)
u32 fbs = readl(port_mmio + PORT_FBS);
int pmp = fbs >> PORT_FBS_DWE_OFFSET;
- if ((fbs & PORT_FBS_SDE) && (pmp < ap->nr_pmp_links) &&
- ata_link_online(&ap->pmp_link[pmp])) {
+ if ((fbs & PORT_FBS_SDE) && (pmp < ap->nr_pmp_links)) {
link = &ap->pmp_link[pmp];
fbs_need_dec = true;
}
--
1.8.1.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ahci: remove pmp link online check in FBS EH
2013-06-08 8:00 [PATCH] ahci: remove pmp link online check in FBS EH Shane Huang
@ 2013-06-09 9:59 ` Liu Yu
2013-06-09 21:59 ` Tejun Heo
1 sibling, 0 replies; 3+ messages in thread
From: Liu Yu @ 2013-06-09 9:59 UTC (permalink / raw)
To: Shane Huang; +Cc: Tejun Heo, linux-ide, stable
On Sat, Jun 8, 2013 at 4:00 PM, Shane Huang <shane.huang@amd.com> wrote:
>
> ata_link_online() check in ahci_error_intr() is unnecessary, it should
> be removed otherwise may lead to lockup with FBS enabled PMP.
> http://marc.info/?l=linux-ide&m=137050421603272&w=2
>
This works for me.
Thanks Shane and Tejun!
Liu Yu
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ahci: remove pmp link online check in FBS EH
2013-06-08 8:00 [PATCH] ahci: remove pmp link online check in FBS EH Shane Huang
2013-06-09 9:59 ` Liu Yu
@ 2013-06-09 21:59 ` Tejun Heo
1 sibling, 0 replies; 3+ messages in thread
From: Tejun Heo @ 2013-06-09 21:59 UTC (permalink / raw)
To: Shane Huang; +Cc: Yu Liu, linux-ide, stable
On Sat, Jun 08, 2013 at 04:00:16PM +0800, Shane Huang wrote:
> ata_link_online() check in ahci_error_intr() is unnecessary, it should
> be removed otherwise may lead to lockup with FBS enabled PMP.
> http://marc.info/?l=linux-ide&m=137050421603272&w=2
>
> Reported-by: Yu Liu <liuyu.ac@gmail.com>
> Signed-off-by: Shane Huang <shane.huang@amd.com>
> Cc: stable@vger.kernel.org
Applied to libata/for-3.10-fixes. Thanks.
--
tejun
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-09 21:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-08 8:00 [PATCH] ahci: remove pmp link online check in FBS EH Shane Huang
2013-06-09 9:59 ` Liu Yu
2013-06-09 21:59 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).