From: Tejun Heo <tj@kernel.org>
To: Gwendal Grignou <gwendal@google.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] ata: cleanup SAT error translation
Date: Mon, 17 Jun 2013 12:48:55 -0700 [thread overview]
Message-ID: <20130617194855.GL32663@mtj.dyndns.org> (raw)
In-Reply-To: <1371242913-10899-1-git-send-email-gwendal@google.com>
Hello, Gwendal.
On Fri, Jun 14, 2013 at 01:48:33PM -0700, Gwendal Grignou wrote:
> Remove duplicate Medium Error Entry.
> Remove the ABRT entry: it is too broad: when only ABRT is set
> we should look at status for more information.
> Only if status does not provide information we set ABORTED_COMMAND
> sense key.
>
> Tested: When a disk fails, it sets
> Status = 0x71 [DRDY DF ERR] , Error = 0x4 [ABRT]
> Ensure the sense key is HARDWARE_ERROR.
> When there is a simple command syntax error:
> Status = 0x51 [DRDY ERR] , Error = 0x4 [ABRT]
> Ensure the sense key is ABORTED_COMMAND.
But this would trigger "no sense translation" warning. The
translation in that function is pretty simplistic anyway. Can you
please update the patch so that there's a comment noting why we aren't
mapping 0x04 and drop the warning?
Thanks.
--
tejun
next prev parent reply other threads:[~2013-06-17 19:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-14 20:48 [PATCH] ata: cleanup SAT error translation Gwendal Grignou
2013-06-17 19:48 ` Tejun Heo [this message]
2013-06-18 17:54 ` [PATCH v2] " Gwendal Grignou
2013-06-18 18:37 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130617194855.GL32663@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=gwendal@google.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).