From: Tejun Heo <tj@kernel.org>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: linux-ide@vger.kernel.org, aaron.lu@intel.com
Subject: Re: [PATCH] libata-zpodd: must use ata_tf_init()
Date: Mon, 24 Jun 2013 15:46:31 -0700 [thread overview]
Message-ID: <20130624224631.GN1918@mtj.dyndns.org> (raw)
In-Reply-To: <201306232325.04732.sergei.shtylyov@cogentembedded.com>
On Sun, Jun 23, 2013 at 11:25:04PM +0400, Sergei Shtylyov wrote:
> There are some SATA controllers which have both devices 0 and 1 but this module
> just zeroes out taskfile and sets then ATA_TFLAG_DEVICE (not sure that's needed)
> which could lead to a wrong device being selected just before issuing command.
> Thus we should call ata_tf_init() which sets up the device register value
> properly, like all other users of ata_exec_internal() do...
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Applied to libata/for-3.11 w/ stable cc'd.
Thanks.
--
tejun
next prev parent reply other threads:[~2013-06-24 22:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-23 19:25 [PATCH] libata-zpodd: must use ata_tf_init() Sergei Shtylyov
2013-06-23 19:34 ` Sergei Shtylyov
2013-06-24 22:46 ` Tejun Heo [this message]
2013-06-26 2:05 ` Aaron Lu
2013-06-26 11:10 ` Sergei Shtylyov
2013-06-27 1:15 ` Aaron Lu
2013-06-28 12:49 ` Sergei Shtylyov
2013-06-29 13:04 ` Aaron Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130624224631.GN1918@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=aaron.lu@intel.com \
--cc=linux-ide@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).