linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] AHCI: use ATA_BUSY
@ 2013-06-22 21:39 Sergei Shtylyov
  2013-06-24 23:30 ` Tejun Heo
  0 siblings, 1 reply; 2+ messages in thread
From: Sergei Shtylyov @ 2013-06-22 21:39 UTC (permalink / raw)
  To: linux-ide, tj

ahci_hardreset() and ahci_p5wdh_hardreset() use bare numbers for the BSY bit of
the  ATA status  register, despite it's #define'd in <linux/ata.h>.

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
The patch is against the 'for-3.11' branch of Tejun Heo's 'libata.git' repo. 

 drivers/ata/ahci.c    |    2 +-
 drivers/ata/libahci.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Index: libata/drivers/ata/ahci.c
===================================================================
--- libata.orig/drivers/ata/ahci.c
+++ libata/drivers/ata/ahci.c
@@ -583,7 +583,7 @@ static int ahci_p5wdh_hardreset(struct a
 
 	/* clear D2H reception area to properly wait for D2H FIS */
 	ata_tf_init(link->device, &tf);
-	tf.command = 0x80;
+	tf.command = ATA_BUSY;
 	ata_tf_to_fis(&tf, 0, 0, d2h_fis);
 
 	rc = sata_link_hardreset(link, sata_ehc_deb_timing(&link->eh_context),
Index: libata/drivers/ata/libahci.c
===================================================================
--- libata.orig/drivers/ata/libahci.c
+++ libata/drivers/ata/libahci.c
@@ -1413,7 +1413,7 @@ static int ahci_hardreset(struct ata_lin
 
 	/* clear D2H reception area to properly wait for D2H FIS */
 	ata_tf_init(link->device, &tf);
-	tf.command = 0x80;
+	tf.command = ATA_BUSY;
 	ata_tf_to_fis(&tf, 0, 0, d2h_fis);
 
 	rc = sata_link_hardreset(link, timing, deadline, &online,

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-06-24 23:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-22 21:39 [PATCH v2] AHCI: use ATA_BUSY Sergei Shtylyov
2013-06-24 23:30 ` Tejun Heo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).