From: Tejun Heo <tj@kernel.org>
To: Richard Zhu <richard.zhuhongxing@gmail.com>
Cc: shawn.guo@linaro.org, linux-arm-kernel@lists.infradead.org,
jgarzik@pobox.com, avorontsov@ru.mvista.com,
rob.herring@calxeda.com, s.hauer@pengutronix.de,
linux-ide@vger.kernel.org, Richard Zhu <r65037@freescale.com>
Subject: Re: [v3 3/3] sata: imx: add ahci sata support on imx platforms
Date: Fri, 5 Jul 2013 10:43:05 -0700 [thread overview]
Message-ID: <20130705174305.GA28088@mtj.dyndns.org> (raw)
In-Reply-To: <1373017942-12583-4-git-send-email-Hong-Xing.Zhu@freescale.com>
Hello,
On Fri, Jul 05, 2013 at 05:52:22PM +0800, Richard Zhu wrote:
> - CAP_SSS(bit20) of the HOST_CAP is writable, default
> value is '0', should be configured to be '1'
> - bit0 (only one AHCI SATA port on imx6q) of the
> HOST_PORTS_IMPL should be set to be '1'.(default 0)
> - One Vendor Specific register HOST_TIMER1MS(offset:0xe0)
> should be configured regarding to the frequency of AHB
> bus clock.
> - Configurations of the AHCI PHY clock, and the signal
> parameters of the GPR13
Can't you just add a platform specific init callback to ahci_platform?
I don't see how these small differences in init sequence justify a
separate driver.
Thanks.
--
tejun
next prev parent reply other threads:[~2013-07-05 17:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-05 9:52 [PATCH v3 0/3] ahci: enable ahci sata support on imx6q Richard Zhu
2013-07-05 9:52 ` [v3 1/3] ARM: dtsi: enable ahci sata on imx6q platforms Richard Zhu
2013-07-05 9:52 ` [v3 2/3] ARM: imx6q: update the sata bits definitions of gpr13 Richard Zhu
2013-07-05 9:52 ` [v3 3/3] sata: imx: add ahci sata support on imx platforms Richard Zhu
2013-07-05 15:59 ` Sascha Hauer
2013-07-05 16:06 ` Re[2]: " Alexander Shiyan
2013-07-06 1:55 ` Zhu Richard-R65037
2013-07-06 1:54 ` Zhu Richard-R65037
2013-07-05 17:43 ` Tejun Heo [this message]
2013-07-06 2:03 ` Zhu Richard-R65037
2013-07-06 2:07 ` Tejun Heo
2013-07-22 7:02 ` Zhu Richard-R65037
2013-07-23 16:26 ` Tejun Heo
2013-07-24 2:21 ` Zhu Richard-R65037
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130705174305.GA28088@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=avorontsov@ru.mvista.com \
--cc=jgarzik@pobox.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=r65037@freescale.com \
--cc=richard.zhuhongxing@gmail.com \
--cc=rob.herring@calxeda.com \
--cc=s.hauer@pengutronix.de \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).