From: Tejun Heo <tj@kernel.org>
To: Zhu Richard-R65037 <r65037@freescale.com>
Cc: Richard Zhu <richard.zhuhongxing@gmail.com>,
"shawn.guo@linaro.org" <shawn.guo@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"jgarzik@pobox.com" <jgarzik@pobox.com>,
"avorontsov@ru.mvista.com" <avorontsov@ru.mvista.com>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Subject: Re: [v3 3/3] sata: imx: add ahci sata support on imx platforms
Date: Fri, 5 Jul 2013 19:07:37 -0700 [thread overview]
Message-ID: <20130706020737.GA9029@mtj.dyndns.org> (raw)
In-Reply-To: <0E83723C55F66F43A6041464FE31119D31432D@039-SN2MPN1-012.039d.mgd.msft.net>
Hello,
On Sat, Jul 06, 2013 at 02:03:30AM +0000, Zhu Richard-R65037 wrote:
> [Richard] Just like what we dicussed in the previous v1/v2
> patch-set. Shawn has the concerns that the IP speicific codes
> shouldn't be put in the platform level. So he suggested that setup
> a stand-alone driver, contained the imx6q ahci sata specific codes,
> and re-use the generic ahci_platform driver as much as possible.
> This imx6q standalone ahci sata driver just registers the platform
> data, and the others would be handled by ahci_platform driver.
Oh, I'm not objecting to the ahci specific part not being in platform
code. I'm wondering whether specific handling for imx6q can be
included into ahci_platform rather than being in its own driver. It
just seems that there aren't too many differences. I could be
misreading it so if there are enough differences to warrant a separate
driver, please enlighten me.
Thanks!
--
tejun
next prev parent reply other threads:[~2013-07-06 2:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-05 9:52 [PATCH v3 0/3] ahci: enable ahci sata support on imx6q Richard Zhu
2013-07-05 9:52 ` [v3 1/3] ARM: dtsi: enable ahci sata on imx6q platforms Richard Zhu
2013-07-05 9:52 ` [v3 2/3] ARM: imx6q: update the sata bits definitions of gpr13 Richard Zhu
2013-07-05 9:52 ` [v3 3/3] sata: imx: add ahci sata support on imx platforms Richard Zhu
2013-07-05 15:59 ` Sascha Hauer
2013-07-05 16:06 ` Re[2]: " Alexander Shiyan
2013-07-06 1:55 ` Zhu Richard-R65037
2013-07-06 1:54 ` Zhu Richard-R65037
2013-07-05 17:43 ` Tejun Heo
2013-07-06 2:03 ` Zhu Richard-R65037
2013-07-06 2:07 ` Tejun Heo [this message]
2013-07-22 7:02 ` Zhu Richard-R65037
2013-07-23 16:26 ` Tejun Heo
2013-07-24 2:21 ` Zhu Richard-R65037
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130706020737.GA9029@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=avorontsov@ru.mvista.com \
--cc=jgarzik@pobox.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=r65037@freescale.com \
--cc=richard.zhuhongxing@gmail.com \
--cc=rob.herring@calxeda.com \
--cc=s.hauer@pengutronix.de \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).