From: Sascha Hauer <s.hauer@pengutronix.de>
To: Zhu Richard-R65037 <r65037@freescale.com>
Cc: Richard Zhu <richard.zhuhongxing@gmail.com>,
"shawn.guo@linaro.org" <shawn.guo@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"jgarzik@pobox.com" <jgarzik@pobox.com>,
"tj@kernel.org" <tj@kernel.org>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Subject: Re: [v4 3/3] sata: imx: add ahci sata support on imx platforms
Date: Thu, 11 Jul 2013 09:55:43 +0200 [thread overview]
Message-ID: <20130711075543.GG14452@pengutronix.de> (raw)
In-Reply-To: <0E83723C55F66F43A6041464FE31119D32AE6B@039-SN2MPN1-013.039d.mgd.msft.net>
Hi Richard,
On Thu, Jul 11, 2013 at 07:50:50AM +0000, Zhu Richard-R65037 wrote:
> Hi Sascha:
> Sorry to make a mess on the usage of the private data.
> The private data of "imx_ahci_pdev" platform device would be used to store ata_host point.
> I shouldn't set imxpriv to the private data of "imx_ahci_pdev", so do the wrong assignment of
> The private pointer of device.
Please allocate your private data along with the platform_device in the
probe function, then in the init callback you can use container_of() to
get a pointer to the data.
Also I would recommend you to request the necessary resources (clocks,
regmap) in the probe function and not in the init callback.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2013-07-11 7:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 8:35 [PATCH v4 0/3] ahci: enable ahci sata support on imx6q Richard Zhu
2013-07-10 8:35 ` [v4 1/3] ARM: dtsi: enable ahci sata on imx6q platforms Richard Zhu
2013-07-10 8:35 ` [v4 2/3] ARM: imx6q: update the sata bits definitions of gpr13 Richard Zhu
2013-07-10 8:35 ` [v4 3/3] sata: imx: add ahci sata support on imx platforms Richard Zhu
2013-07-10 21:04 ` Sascha Hauer
2013-07-11 7:50 ` Zhu Richard-R65037
2013-07-11 7:55 ` Sascha Hauer [this message]
2013-07-11 9:07 ` Zhu Richard-R65037
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130711075543.GG14452@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=jgarzik@pobox.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=r65037@freescale.com \
--cc=richard.zhuhongxing@gmail.com \
--cc=rob.herring@calxeda.com \
--cc=shawn.guo@linaro.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox