From: Tejun Heo <tj@kernel.org>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: move 'struct ata_taskfile' and friends from ata.h to libata.h
Date: Tue, 16 Jul 2013 05:47:29 -0600 [thread overview]
Message-ID: <20130716114729.GA23827@mtj.dyndns.org> (raw)
In-Reply-To: <201307010001.32816.sergei.shtylyov@cogentembedded.com>
On Mon, Jul 01, 2013 at 12:01:32AM +0400, Sergei Shtylyov wrote:
> From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
>
> Move 'struct ata_taskfile', ata_prot_flags() and their friends from
> <linux/ata.h> to <linux/libata.h>. They were misplaced from the beginning, as
> <linux/ata.h> should cover ATA/ATAPI and related standards only -- to which the
> aforementioned structure and function have only remote relation.
>
> I would have moved 'enum ata_tf_protocols' closely related to 'struct
> ata_taskfile' but it unfortunately gets used by 'drivers/ide/ide-ioctls.c'...
>
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Applied to libata/for-3.12. Thanks!
--
tejun
prev parent reply other threads:[~2013-07-16 11:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-30 20:01 [PATCH] libata: move 'struct ata_taskfile' and friends from ata.h to libata.h Sergei Shtylyov
2013-07-16 11:47 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130716114729.GA23827@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).