From: Tejun Heo <tj@kernel.org>
To: Martin Braure de Calignon <braurede@free.fr>
Cc: Ben Hutchings <ben@decadent.org.uk>,
714295@bugs.debian.org, linux-ide@vger.kernel.org,
risc4all@yahoo.com
Subject: [PATCH libata/for-3.11-fixes] libata: make it clear that sata_inic162x is experimental
Date: Mon, 22 Jul 2013 17:13:07 -0400 [thread overview]
Message-ID: <20130722211307.GA16776@mtj.dyndns.org> (raw)
In-Reply-To: <1372668742.17064.23.camel@phoenix>
Hello, guys.
I've committed the following patch to for-3.11-fixes. It's
unfortunate but I can't see a good way out at this point. :(
Thanks.
------------- 8< ----------------
>From bb9696192826a7d9279caf872e95b41bc26c7eff Mon Sep 17 00:00:00 2001
From: Tejun Heo <tj@kernel.org>
Date: Mon, 22 Jul 2013 16:53:36 -0400
sata_inic162x never reached a state where it's reliable enough for
production use and data corruption is a relatively common occurrence.
Make the driver generate warning about the issues and mark the Kconfig
option as experimental.
If the situation doesn't improve, we'd be better off making it depend
on CONFIG_BROKEN. Let's wait for several cycles and see if the kernel
message draws any attention.
Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Martin Braure de Calignon <braurede@free.fr>
Reported-by: Ben Hutchings <ben@decadent.org.uk>
Reported-by: risc4all@yahoo.com
---
drivers/ata/Kconfig | 2 +-
drivers/ata/sata_inic162x.c | 14 ++++++++++++++
2 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 80dc988..5cddaf8 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -107,7 +107,7 @@ config SATA_FSL
If unsure, say N.
config SATA_INIC162X
- tristate "Initio 162x SATA support"
+ tristate "Initio 162x SATA support (Very Experimental)"
depends on PCI
help
This option enables support for Initio 162x Serial ATA.
diff --git a/drivers/ata/sata_inic162x.c b/drivers/ata/sata_inic162x.c
index e451317..5c54d95 100644
--- a/drivers/ata/sata_inic162x.c
+++ b/drivers/ata/sata_inic162x.c
@@ -6,6 +6,18 @@
*
* This file is released under GPL v2.
*
+ * **** WARNING ****
+ *
+ * This driver never worked properly and unfortunately data corruption is
+ * relatively common. There isn't anyone working on the driver and there's
+ * no support from the vendor. Do not use this driver in any production
+ * environment.
+ *
+ * http://thread.gmane.org/gmane.linux.debian.devel.bugs.rc/378525/focus=54491
+ * https://bugzilla.kernel.org/show_bug.cgi?id=60565
+ *
+ * *****************
+ *
* This controller is eccentric and easily locks up if something isn't
* right. Documentation is available at initio's website but it only
* documents registers (not programming model).
@@ -807,6 +819,8 @@ static int inic_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
ata_print_version_once(&pdev->dev, DRV_VERSION);
+ dev_alert(&pdev->dev, "inic162x support is broken with common data corruption issues and will be disabled by default, contact linux-ide@vger.kernel.org if in production use\n");
+
/* alloc host */
host = ata_host_alloc_pinfo(&pdev->dev, ppi, NR_PORTS);
hpriv = devm_kzalloc(&pdev->dev, sizeof(*hpriv), GFP_KERNEL);
--
1.8.3.1
next prev parent reply other threads:[~2013-07-22 21:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130627160606.3447.9939.reportbug@storm.xmen.local>
[not found] ` <20130627165114.GK4752@decadent.org.uk>
[not found] ` <1372353297.24346.4.camel@phoenix>
[not found] ` <20130627173142.GM4752@decadent.org.uk>
[not found] ` <1372375714.330.17.camel@phoenix>
[not found] ` <1372383087.23847.35.camel@deadeye.wl.decadent.org.uk>
[not found] ` <1372427725.23094.17.camel@phoenix>
2013-06-30 14:49 ` Data corruption when using INIC-1623TA2 controller Ben Hutchings
2013-07-01 6:17 ` Tejun Heo
2013-07-01 8:52 ` Martin Braure de Calignon
2013-07-22 21:13 ` Tejun Heo [this message]
2013-07-26 4:57 ` [PATCH libata/for-3.11-fixes] libata: make it clear that sata_inic162x is experimental Ben Hutchings
2013-07-26 12:46 ` Tejun Heo
2013-07-29 16:52 ` Tejun Heo
2013-08-01 3:15 ` Greg Kroah-Hartman
2013-08-02 14:44 ` Luis Henriques
2013-08-31 20:17 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130722211307.GA16776@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=714295@bugs.debian.org \
--cc=ben@decadent.org.uk \
--cc=braurede@free.fr \
--cc=linux-ide@vger.kernel.org \
--cc=risc4all@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).