Linux ATA/IDE development
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Richard Zhu <richard.zhuhongxing@gmail.com>
Cc: shawn.guo@linaro.org, linux-arm-kernel@lists.infradead.org,
	jgarzik@pobox.com, rob.herring@calxeda.com,
	s.hauer@pengutronix.de, linux-ide@vger.kernel.org,
	Richard Zhu <r65037@freescale.com>
Subject: Re: [v8 3/3] ahci_imx: add ahci sata support on imx platforms
Date: Wed, 24 Jul 2013 12:30:38 -0400	[thread overview]
Message-ID: <20130724163038.GF20377@mtj.dyndns.org> (raw)
In-Reply-To: <1374646529-24432-4-git-send-email-Hong-Xing.Zhu@freescale.com>

On Wed, Jul 24, 2013 at 02:15:29PM +0800, Richard Zhu wrote:
> From: Richard Zhu <r65037@freescale.com>
> 
> imx6q contains one Synopsys AHCI SATA controller,
> But it can't share ahci_platform driver with other
> controllers.
> Because there are some misalignments of the generic
> AHCI controller.
> The bits definitions of the HBA registers, the Vendor
> Specific registers, the AHCI PHY clock and the AHCI
> signals adjustment window(GPR13 register).
>  - CAP_SSS(bit20) of the HOST_CAP is writable, default
>  value is '0', should be configured to be '1'
>  - bit0 (only one AHCI SATA port on imx6q) of the
>  HOST_PORTS_IMPL should be set to be '1'.(default 0)
>  - One Vendor Specific register HOST_TIMER1MS(offset:0xe0)
>  should be configured regarding to the frequency of AHB
>  bus clock.
>  - Configurations of the AHCI PHY clock, and the signal
>  parameters of the GPR13
> 
> Setup its own ahci sata driver, contained the imx6q specific
> initialized codes, re-use the generic ahci_platform driver, and
> keep the generic ahci_platform driver clean as much as possible.
> 
> Signed-off-by: Richard Zhu <r65037@freescale.com>
> Reviewed-by: Shawn Guo <shawn.guo@linaro.org>

Applied 2-3 to libata/for-3.11-fixes with minor adjustments.

Thanks.

-- 
tejun

  reply	other threads:[~2013-07-24 16:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-24  6:15 [PATCH v8 0/3] ahci: enable ahci sata support on imx6q Richard Zhu
2013-07-24  6:15 ` [v8 1/3] ARM: dtsi: enable ahci sata on imx6q platforms Richard Zhu
2013-07-24  6:15 ` [v8 2/3] ARM: imx6q: update the sata bits definitions of gpr13 Richard Zhu
2013-07-24  6:15 ` [v8 3/3] ahci_imx: add ahci sata support on imx platforms Richard Zhu
2013-07-24 16:30   ` Tejun Heo [this message]
2013-07-25  1:32     ` Zhu Richard-R65037

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130724163038.GF20377@mtj.dyndns.org \
    --to=tj@kernel.org \
    --cc=jgarzik@pobox.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=r65037@freescale.com \
    --cc=richard.zhuhongxing@gmail.com \
    --cc=rob.herring@calxeda.com \
    --cc=s.hauer@pengutronix.de \
    --cc=shawn.guo@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox